Skip to content

Fix cudf.pandas Timestamp/Timedelta not subclassing stdlib datetime objects #20433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Fix cudf.pandas Timestamp/Timedelta not subclassing stdlib datetime objects #20433

wants to merge 16 commits into from
+75 −570

Conversation

@mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Oct 30, 2025

Description

closes #20423

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke self-assigned this Oct 30, 2025
@mroeschke mroeschke requested a review from a team as a code owner October 30, 2025 17:44
@mroeschke mroeschke added the bug Something isn't working label Oct 30, 2025
@mroeschke mroeschke requested a review from Matt711 October 30, 2025 17:44
@mroeschke mroeschke added non-breaking Non-breaking change cudf.pandas Issues specific to cudf.pandas labels Oct 30, 2025
@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 30, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Oct 30, 2025
@galipremsagar
Copy link
Contributor

galipremsagar commented Oct 30, 2025

This is awesome @mroeschke !

@mroeschke
Copy link
Contributor Author

mroeschke commented Nov 4, 2025

@galipremsagar I could use your help with the test_pickle failures in the cudf.pandas tests. I see #17980 modified the pickling operations for proxy classes but I'm not certain how to update the dispatcher to account for the new base class

@galipremsagar
Copy link
Contributor

galipremsagar commented Nov 4, 2025

@galipremsagar I could use your help with the test_pickle failures in the cudf.pandas tests. I see #17980 modified the pickling operations for proxy classes but I'm not certain how to update the dispatcher to account for the new base class

I'm looking into it.

@galipremsagar
Copy link
Contributor

galipremsagar commented Nov 5, 2025

Found a fix, will push first thing tomorrow.

Matt711
Matt711 approved these changes Nov 5, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@Matt711 Matt711 Matt711 approved these changes

Assignees

@mroeschke mroeschke

@galipremsagar galipremsagar

Labels

bug Something isn't working cudf.pandas Issues specific to cudf.pandas non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

cuDF Python
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] pandas.Timestamp/Timedelta not an instance of datetime.datetime/timedelta

3 participants

@mroeschke @galipremsagar @Matt711