Skip to content

Fix OOB memory access in JSON reader ingest_raw utility #20451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 3, 2025
Merged

Fix OOB memory access in JSON reader ingest_raw utility #20451

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4fe5553
Fix OOB memory access in JSON reader ingest_raw utility
davidwendt Oct 31, 2025
279596a
adjust data-size to account for the maximum buffer size
davidwendt Oct 31, 2025
7d086f8
Merge branch 'main' into oob-json-reader
davidwendt Nov 3, 2025
1d5257c
test fix from Shruti
davidwendt Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cpp/src/io/json/read_json.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,8 +686,10 @@ device_span<char> ingest_raw_input(device_span<char> buffer,
} else {
h_buffers.emplace_back(sources[i]->host_read(range_offset, data_size));
auto const& h_buffer = h_buffers.back();
auto const max_size = std::distance(destination, reinterpret_cast<uint8_t*>(buffer.end()));
auto const copy_size = std::min(static_cast<size_t>(max_size), h_buffer->size());
CUDF_CUDA_TRY(cudaMemcpyAsync(
destination, h_buffer->data(), h_buffer->size(), cudaMemcpyHostToDevice, stream.value()));
destination, h_buffer->data(), copy_size, cudaMemcpyDefault, stream.value()));
bytes_read += h_buffer->size();
}
range_offset = 0;
Expand Down Expand Up @@ -720,7 +722,9 @@ device_span<char> ingest_raw_input(device_span<char> buffer,
"Incorrect number of bytes read by multithreaded reader");
}

return buffer.first(bytes_read + (delimiter_map.size() * num_delimiter_chars));
auto const return_size =
std::min(buffer.size(), bytes_read + (delimiter_map.size() * num_delimiter_chars));
return buffer.first(return_size);
}

table_with_metadata read_json(host_span<std::unique_ptr<datasource>> sources,
Expand Down