Allow early exit for left semi-/anti- joins with empty build/probe tables #20452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
davidwendt
approved these changes
Oct 31, 2025
Contributor
davidwendt
left a comment
davidwendt
left a comment
There was a problem hiding this comment.
LGTM. Just one suggestion.
vyasr
reviewed
Oct 31, 2025
Contributor
vyasr
left a comment
vyasr
left a comment
There was a problem hiding this comment.
Looks fine. The test failures look unrelated, maybe a bad runner state?
vyasr
approved these changes
Oct 31, 2025
Co-authored-by: David Wendt <[email protected]>
Contributor
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #20410
Adds early exit condition in filtered join operations when input tables are empty. Includes test coverage for semi- and anti- join operations with empty table scenarios.
Checklist