feat(wheels,conda): support passing RAPIDS_PACKAGE_NAME from build step to artifact upload
#435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If set to `true`, the `MATRIX_FILTER` is reduced to a single build on `amd64` with the latest version of `PY_VER`
If it is `true`, then we set it in the `test` job
gforsyth
added
improvement
gforsyth
changed the title
noarch: pythonRAPIDS_PACKAGE_NAME from build step to artifact upload
vyasr
approved these changes
Nov 4, 2025
Contributor
vyasr
left a comment
vyasr
left a comment
There was a problem hiding this comment.
Needs conflict resolution, and the two comments are probably related to the cause of conflict, but otherwise LGTM.
Co-authored-by: Vyas Ramasubramani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in support of (part of) rapidsai/build-planning#204
There are other changes that are in
gha-toolsfor how to configure the artifact names for uploading and downloading interim wheels and conda packages (rapidsai/gha-tools#218 rapidsai/gha-tools#219).The change here is to allow setting the value of
RAPIDS_PACKAGE_NAMEin a downstream build script and then having that value passed to theGet package namestep so that we have the option to configure artifact names on a per-job basis.