Fix checkbox in dark mode

[sotten]

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

The checkboxes do not work properly in dark mode with Tailwind. Resolves #1199

Style testet with Chromium Version 129 and [email protected]:

	Dark	Light
Unchecked
Checked
Unchecked focus
Checked focus

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.86%. Comparing base (0c8ec45) to head (304bb0a).
Report is 202 commits behind head on development.

Additional details and impacted files

@@                Coverage Diff                @@
##             development    #2051      +/-   ##
=================================================
+ Coverage          87.30%   87.86%   +0.56%     
- Complexity          1672     1934     +262     
=================================================
  Files                150      184      +34     
  Lines               3891     4426     +535     
=================================================
+ Hits                3397     3889     +492     
- Misses               494      537      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[lrljoe]

Will review tomorrow, as with the shifting of the order of the classes, I just need to double check that any existing classes haven't been replaced.

[sotten]

I have used the order of classes recommended by Tailwind:
https://tailwindcss.com/blog/automatic-class-sorting-with-prettier#how-classes-are-sorted

I use the following plugin from Tailwindlabs local: https://github.com/tailwindlabs/prettier-plugin-tailwindcss

I can change the order back to the original if you like.
Maybe it would be useful for the future to include the Prettier plugin in github action. Helpful tutorial: https://akhilaariyachandra.com/blog/prettier-in-github-actions

[lrljoe]

Some of the below are superfluous, but any removals will need to be validated.

resources/views/components/table/td/bulk-actions.blade.php

Removed From Current
dark:text-white dark:hover:bg-gray-600 dark:focus:bg-gray-600

Added To Current
dark:checked:bg-indigo-500

resources/views/components/table/th/bulk-actions.blade.php

Removed From Current
dark:text-white dark:hover:bg-gray-600 dark:focus:bg-gray-600

Added To Current
dark:checked:bg-indigo-500

resources/views/components/tools/filters/multi-select.blade.php

Removed From Current
dark:text-white dark:hover:bg-gray-600 dark:focus:bg-gray-600

Added To Current
dark:checked:bg-indigo-500

Removed From Current
dark:text-white dark:hover:bg-gray-600 dark:focus:bg-gray-600
Added To Current
dark:checked:bg-indigo-500

resources/views/components/tools/toolbar/items/column-select.blade.php

Removed From Current
class=" dark:text-white dark:hover:bg-gray-600 dark:focus:bg-gray-600 "

Added To Current
class=" dark:checked:bg-indigo-500 "

Removed From Current
class=" dark:text-white dark:hover:bg-gray-600 dark:focus:bg-gray-600 "

Added To Current
class=" dark:checked:bg-indigo-500 "

[sotten]

Yes, that is intentional.

[lrljoe]

Yes, that is intentional.

Not so much objection, more to remind myself when I review this further

[lrljoe]

Having reviewed this, it removes an existing behaviour (hover/focus classes on checkboxes), which is what the ~2m projects using the package have come to expect.

Therefore this PR is rejected.

There is an upcoming update that will add more customisation in for users who wish to change the default attributes on filter inputs.