staging: vc04_services: vc-sm-cma: Fix smatch warnings #7116
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix these two smatch warnings for the vc-sm-cma driver, rest were false positives: ../vc-sm-cma/vc_sm.c:413 vc_sm_dma_buf_attach() warn: inconsistent returns '&buf->lock'. Locked on : 396 Unlocked on: 413 ../vc-sm-cma/vc_sm.c:1225 vc_sm_cma_ioctl_alloc() error: we previously assumed 'buffer' could be null (see line 1113) Signed-off-by: Jai Luthra <[email protected]>
popcornmix
approved these changes
Oct 31, 2025
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Nov 4, 2025
kernel: drm/vc4: plane: Swap Cb/Cr pointers for YVU formats See: raspberrypi/linux#7122 kernel: drm/vc4: plane: Swap Cb/Cr offsets for YVU formats See: raspberrypi/linux#7124 kernel: media: imx477: Increase IMX477_VBLANK_MIN due to image corruption See: raspberrypi/linux#7114 kernel: staging: vc04_services: vc-sm-cma: Fix smatch warnings See: raspberrypi/linux#7116
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Nov 4, 2025
kernel: drm/vc4: plane: Swap Cb/Cr pointers for YVU formats See: raspberrypi/linux#7122 kernel: drm/vc4: plane: Swap Cb/Cr offsets for YVU formats See: raspberrypi/linux#7124 kernel: media: imx477: Increase IMX477_VBLANK_MIN due to image corruption See: raspberrypi/linux#7114 kernel: staging: vc04_services: vc-sm-cma: Fix smatch warnings See: raspberrypi/linux#7116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix these two smatch warnings for the vc-sm-cma driver, rest were false positives:
../vc-sm-cma/vc_sm.c:413
vc_sm_dma_buf_attach() warn: inconsistent returns '&buf->lock'.
Locked on : 396
Unlocked on: 413
../vc-sm-cma/vc_sm.c:1225
vc_sm_cma_ioctl_alloc() error: we previously assumed 'buffer' could be null (see line 1113)
This change is also posted upstream, squashed into the commit introducing support for vc-sm-cma driver:
https://lore.kernel.org/all/[email protected]/T/#t