This repository was archived by the owner on Feb 27, 2023. It is now read-only.
Updated the GPIO Trigger functionality to allow custom GPIO ports #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recovery.cmdline file to the actual program
|
In general, we don't accept PRs which add functionality, but this looks simple enough. If you also add some documentation for the feature, remove the NOOBS version bump and it all works for you as expected, I'm happy to merge. Thanks. |
|
Reverted to V3 and added additional documentation underneath the existing GPIO Trigger part. Added examples so that its hopefully clear |
|
abandoning the PR as I pushed other changes to master, instead created a new PR which has a specific branch containing the changes #546 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now provide the GPIO number and the value you want it to be (e.g 1 or 0) allowing more use case scenarios