-
Notifications
You must be signed in to change notification settings - Fork 964
Add .md to README and clarify what example does #712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Renamed README to README.md to improve how it renders in an IDE and when browsing the online repository. Improved the example description to clarify why the temperature updates might appear unexpectedly sporadic to the user; and document how to read the current led status.
|
Looks good. Just the one typo pointed out by @lurch |
|
FYI #498 is where this example was first added. |
|
Thanks @peterharperuk and well spotted @lurch - fixed in my a23bca5. One of these days I'll manage to get a PR through without a typo 8-) |
Note that start_client() may be called direct from main() - i.e. not in a callback
|
If the dns query returns immediately then start_client() is called directly from main(); so shouldn't the call to mqtt_client_new() be protected? The lwIP implementation has LWIP_ASSERT_CORE_LOCKED |
|
With the greatest respect, although this example is very thorough it is also quite hard to follow. |
Yes |
|
If you have suggestions for other improvements and fixes. I would suggest raising them as separate pull requests. |
The code as stands also calls mqtt_client_is_connected(), which the lwIP code also has the CORE_LOCKED assertion. Not sure whether that's safe or not? |
Uh oh!
There was an error while loading. Please reload this page.