Add support for hard float on M33 via CMake variable PICO_HARD_FLOAT_ABI=1#2822
Merged
Conversation
Resolves #2783 Signed-off-by: Andy Lin <andylinpersonal@gmail.com>
…ith #if defined(__ARM_PCS_VFP)
… mode rather than #define
- splitting out executable for each test type for pico_float/double_test - removing undefined behavior from custom_float_funcs_test.c, to de-confuse clang - add test of denormal->int Note some tests still fail on llvm libc (at least version 19)
This was referenced Feb 8, 2026
Contributor
|
Really looking forward to this! Unless there are serious performance regressions (I expect there will not be) we will enable it in MicroPython. That's because our ABI for dynamically loadable native code only supports |
lurch
reviewed
Feb 9, 2026
lurch
reviewed
Feb 9, 2026
Co-authored-by: Andrew Scheller <andrew.scheller@raspberrypi.com>
Co-authored-by: Andrew Scheller <andrew.scheller@raspberrypi.com>
Wren6991
reviewed
Mar 2, 2026
Wren6991
reviewed
Mar 2, 2026
Wren6991
reviewed
Mar 2, 2026
Wren6991
reviewed
Mar 2, 2026
Wren6991
reviewed
Mar 2, 2026
Wren6991
requested changes
Mar 2, 2026
Contributor
Wren6991
left a comment
There was a problem hiding this comment.
Fairly certain the mismatched push/pop is a bug. Otherwise looks ok, so LGTM once that is re-checked
- fix guard for TEST_SATURATION in pico_double_test - GCC doesn't clamp either
…ble_pico_dcp explicitly (i.e. explicitly setting double impl to pico_dcp was not selecting our versions)
… pop of lr, into a pop of pc
Contributor
|
CI appears to be failing with: |
Contributor
|
Lots of CI failures in the Bazel builds now, e.g. |
…_softfp to be clear that these are the function entry points which work with softfp calling conventions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note there is currently no hard float library in the
llvm_libc