Conversation
|
Note to myself squash before merge |
aa3026e to
2143185
Compare
6931f3a to
7f7eeeb
Compare
|
Now that RP2350 support has been added to probe-rs (probe-rs/probe-rs#3005), I think we can simplify the rust integration to use the "Debugger for probe-rs" extension rather then Cortex-Debug for debugging rust code. This has full support for defmt, so should be easier to integrate. |
I'll look into it. Im currently very busy, but I may find some time in a few weeks. |
7f7eeeb to
3c5947d
Compare
|
@will-v-pi Just updated the generator to use |
|
I think the config used by https://github.com/rp-rs/rp2040-project-template was working for me |
Also for the Pico 2? |
I haven’t tried, but my hope is that with the probe-rs support it should just be a case of changing the chip name in the config? |
|
@will-v-pi It seems like the issue was the missing |
will-v-pi
left a comment
There was a problem hiding this comment.
This is looking great, thanks! I've tested with RP2040 and RP2350, and the only big issue I've found is that RP2350 Risc-V debugging doesn't seem to work, with probe-rs throwing an error. Do you see an error too when doing that? If it's a prope-rs issue, then probably worth putting a note somewhere, so we don't get a bunch of bug reports?
Couple of thoughts:
- We should remove the
-fflag from the Run Project picotool command, as rust projects won't work with that unless you've added it manually - Now rp235x-hal is on crates.io, we can get rid of the submodule and just have
rp235x-hal = { version = "0.3", features = ["rt", "critical-section-impl"] }etc in the Cargo.toml - My new Switch Build Type command isn't getting disabled, like the other CMake commands - probably just missed when rebasing?
- The Debug Project button throws an error "Configuration 'rp2040-project' is missing in 'launch.json'" - I'm guessing that just needs a rename in the command?
- Could we add a Reload Window prompt after switching chips? I've found the existing Restart prompt from rust-analyzer can take a while to restart, and if you click Compile during that time it can get into a broken state
Other than that, this is looking excellent!
2b615cd to
0ad7d63
Compare
|
Note that in the current state first rust project creation with fresh rustup install will take very long. |
|
Just wanted to note that I got an error when compiling a project, because I had an old Cargo version: The link in the error didn't help - the solution was to run |
|
I'm hitting an error on a clean windows install where if I just use the automated rustup installer ( It might be good to filter for that specific |
d019939 to
ae65737
Compare
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Co-authored-by: will-v-pi <108662275+will-v-pi@users.noreply.github.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
Signed-off-by: paulober <paul.oberosler@raspberrypi.com>
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
…ugger selection Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
ec01639 to
a2733c4
Compare
Signed-off-by: paulober <44974737+paulober@users.noreply.github.com>
No description provided.