Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mostly admin updates #137

Closed
wants to merge 10 commits into from
Closed

mostly admin updates #137

wants to merge 10 commits into from

Conversation

fitsum
Copy link

@fitsum fitsum commented Jul 6, 2024

  • package updates
  • add linter
  • remove old lint rc
  • add entry
  • new file
  • lint
  • comment out default values for options + lint
  • add NOTES with notes about commenting out default values in config
  • uncomment default values because they don't seem to interfere with options anymore 🤷
  • remove irrelevant notes

Copy link
Collaborator

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your interest in MapsCII and for contributing to this project. 👍

The addition of the NOTES and TODO files confuse me. Most development ideas are kept in issues on GitHub.

The update of the ESLint config seems very much needed to keep up with new ESLint releases. However, it seems that the rules are not matching the project's current code style and have not been applied to most code files in the src folder.

I wonder what rastapasta thinks.

.eslintrc.json Show resolved Hide resolved
.eslintrc.json Show resolved Hide resolved
src/config.js Show resolved Hide resolved
.eslintrc.json Show resolved Hide resolved
NOTES.md Show resolved Hide resolved
TODO.md Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@fitsum
Copy link
Author

fitsum commented Oct 2, 2024

The rejection is fair.
In the end I don't think the PR was as appropriate as a fork and actually meant to remove it
Thanks for your time reviewing this.

@fitsum fitsum closed this Oct 2, 2024
@fitsum fitsum deleted the develop branch October 2, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants