blacklist kitty detection for WezTerm and Konsole#145
Merged
Conversation
Contributor
|
Merge of 6d5d67b to Screenshots from all terminal emulators: alacritty
Image diff vs master: blackbox
Image diff vs master: contour
Image diff vs master: foot
Image diff vs master: ghostty
Image diff vs master: kitty
Image diff vs master: konsole
Image diff vs master: mlterm
Image diff vs master: rio
Image diff vs master: wezterm
Image diff vs master: xfce4-terminal
Image diff vs master: xterm
Image diff vs master: xterm-vt340
Image diff vs master: |
WezTerm and Konsole do not implement the placeholder part of the kitty spec correctly, so we can just blacklist kitty detection based on their env vars. Same for sixels: WezTerm supports it, but we prefer iterm2, and konsole's sixel implementation leaves some nasty artifacts.
benjajaja
force-pushed
the
konsole_blacklist_kitty
branch
from
caa68b3 to
6d5d67b
Compare
Collaborator
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WezTerm and Konsole do not implement the placeholder part of the kitty spec correctly, so we can just blacklist kitty detection based on their env vars. WezTerm will pick iterm2, and konsole will pick sixel.