-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Node.js] RDoc-3004 Subscriptions > Consumption > Examples #1908
base: master
Are you sure you want to change the base?
[Node.js] RDoc-3004 Subscriptions > Consumption > Examples #1908
Conversation
|
||
{ | ||
// Example: Client with full exception handling and processing retries | ||
// =================================================================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcin pls ping me regarding this example
13b5c40
to
645ee64
Compare
return; | ||
} | ||
|
||
setTimeout(reconnect, 1000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ml054
in this place, do we want to call closeWorker(subscriptionWorker);
instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can dispose it right away + try to reconnect in 1s
Related issue:
https://issues.hibernatingrhinos.com/issue/RDoc-3004/Node.js-Client-API-Data-subscriptions-Consumption-Examples-Replace-C-samples
Notes for this PR:
In this PR
Node.js
was appliedStill, there are fixes to be applied to this article for all languages - to be done in a separate dedicated issue:
https://issues.hibernatingrhinos.com/issue/RDoc-3006/Client-API-Data-subscriptions-Consumption-Examples-Fix-article
Node.js: @ml054