Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Node.js] RDoc-3004 Subscriptions > Consumption > Examples #1908

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Danielle9897
Copy link
Member

Related issue:
https://issues.hibernatingrhinos.com/issue/RDoc-3004/Node.js-Client-API-Data-subscriptions-Consumption-Examples-Replace-C-samples


Notes for this PR:


Node.js: @ml054

  • Node.js files to review:
Documentation/5.4/Raven.Documentation.Pages/client-api/data-subscriptions/consumption/examples.js.markdown
Documentation/5.4/Samples/nodejs/client-api/dataSubscriptions/consumption/examples.js


{
// Example: Client with full exception handling and processing retries
// ===================================================================
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcin pls ping me regarding this example

@Danielle9897 Danielle9897 marked this pull request as draft September 18, 2024 11:01
@Danielle9897 Danielle9897 force-pushed the RDoc-3004-subscription-consumption-examples-for-pr branch from 13b5c40 to 645ee64 Compare September 18, 2024 13:11
@Danielle9897 Danielle9897 marked this pull request as ready for review September 18, 2024 13:14
return;
}

setTimeout(reconnect, 1000);
Copy link
Member Author

@Danielle9897 Danielle9897 Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ml054
in this place, do we want to call closeWorker(subscriptionWorker); instead ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can dispose it right away + try to reconnect in 1s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants