[historyserver] Ensure at least one worker in sample RayCluster #4330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Future-Outlier <[email protected]>
Future-Outlier
commented
Jan 2, 2026
Member
Author
Future-Outlier
left a comment
Future-Outlier
left a comment
There was a problem hiding this comment.
- cc @rueian to merge
- cc @JiangJiaWei1103 to write tests to test both head pod and worker pod, note that in head node's folder, we will have additional logs like gcs_server.out.
Signed-off-by: Future-Outlier <[email protected]>
…mple-worker-min-replica-1
win5923
approved these changes
Jan 2, 2026
win5923
reviewed
Jan 2, 2026
Co-authored-by: Jun-Hao Wan <[email protected]> Signed-off-by: Han-Ju Chen (Future-Outlier) <[email protected]>
JiangJiaWei1103
approved these changes
Jan 3, 2026
Contributor
JiangJiaWei1103
left a comment
JiangJiaWei1103
left a comment
There was a problem hiding this comment.
Make sense to test scenarios including workers!
I'll cover these cases in e2e tests. Thanks!
rueian
approved these changes
Jan 6, 2026
github-project-automation
bot
moved this from can be merged
to Done
in @Future-Outlier's kuberay project
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We should test the history server with both a head node and at least one worker node; this makes it easier to find bugs.
How I test it?
This directory contains two subdirectories: one for the head node and the other for the worker node.
E2E test passed
Related issue number
#4274
Checks