Disable the field alignment lint check#4560
Open
jinbum-kim wants to merge 2 commits intoray-project:masterfrom
Open
Disable the field alignment lint check#4560jinbum-kim wants to merge 2 commits intoray-project:masterfrom
jinbum-kim wants to merge 2 commits intoray-project:masterfrom
Conversation
Signed-off-by: jinbum9958 <jinbum9958@gmail.com>
Signed-off-by: jinbum9958 <jinbum9958@gmail.com>
jinbum-kim
requested review from
MortalHappiness,
andrewsykim,
kevin85421 and
rueian
as code owners
andrewsykim
requested changes
Mar 4, 2026
| // +kubebuilder:resource:categories=all | ||
| // +kubebuilder:storageversion | ||
| // | ||
| //nolint:govet // RayCronJob is the Schema for the raycronjobs API |
Member
There was a problem hiding this comment.
Keep the original comment // RayCronJob is the Schema for the raycronjobs API
| // EDIT THIS FILE! THIS IS SCAFFOLDING FOR YOU TO OWN! | ||
| // NOTE: json tags are required. Any new fields you add must have json tags for the fields to be serialized. | ||
|
|
||
| //nolint:govet // RayCronJobSpec defines the desired state of RayCronJob |
Member
There was a problem hiding this comment.
Keep original comment // RayCronJobSpec defines the desired state of RayCronJob
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR is related to #4557.
This PR disables the
govetfieldalignmentanalyzer in golangci-lint configuration to reduce lint noise and avoid forcing struct field reordering for readability reasons.As a follow-up to disabling it, the
golangci-lintpre-commit hook updated a couple of files by removing now-unnecessary//nolint:govetannotations.Related issue number
closes #4557
Checks