[core][autoscaler][v1] prune IPs from the LoadMetrics after terminating nodes #52409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
force-pushed
the
update-loadmetrics-after-node-terminations
branch
from
710b437 to
436418e
Compare
rueian
force-pushed
the
update-loadmetrics-after-node-terminations
branch
2 times, most recently
from
07e32e6 to
d89718c
Compare
|
cc @dayshah for review. Thanks! |
rueian
commented
Apr 18, 2025
Comment on lines
+3623
to
+3625
| assert lm.is_active(worker_ip) | ||
| autoscaler.update() | ||
| assert not lm.is_active(worker_ip) |
There was a problem hiding this comment.
lm.is_active(worker_ip) should still be True before autoscaler.update().
lm.is_active(worker_ip) should be False after autoscaler.update() because the idle worker_ip should be pruned by the change in this PR.
rueian
force-pushed
the
update-loadmetrics-after-node-terminations
branch
from
d89718c to
f46a3e4
Compare
…ng nodes Co-authored-by: Dongjun Na <[email protected]> Signed-off-by: Rueian <[email protected]>
rueian
force-pushed
the
update-loadmetrics-after-node-terminations
branch
from
f46a3e4 to
caa1c00
Compare
|
Gently ping @kevin85421 and @jjyao for reviews. |
|
I will discuss this PR with @rueian offline. |
kevin85421
reviewed
Apr 23, 2025
| @@ -437,6 +425,18 @@ def _update(self): | |||
| self.attempt_to_recover_unhealthy_nodes(now) | |||
| self.set_prometheus_updater_data() | |||
|
|
|||
| # Update running nodes gauge | |||
There was a problem hiding this comment.
Note: L406 - L426 update the list of alive nodes (i.e. non_terminated_nodes). This PR uses the updated list to update load metrics.
| num_workers = len(self.non_terminated_nodes.worker_ids) | ||
| self.prom_metrics.running_workers.set(num_workers) | ||
|
|
||
| # Remove from LoadMetrics the ips unknown to the NodeProvider. |
There was a problem hiding this comment.
This comment is not easy to understand. Would you mind updating the comment?
…ng nodes Signed-off-by: Rueian <[email protected]>
kevin85421
approved these changes
Apr 23, 2025
|
cc @jjyao for merge or review |
ktyxx
pushed a commit
to ktyxx/ray
that referenced
this pull request
Apr 29, 2025
…ng nodes (ray-project#52409) Signed-off-by: Rueian <[email protected]>
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, the autoscaler remove unwanted IPs from the LoadMetrics before terminating idle and dead nodes, therefore those nodes' IPs will be left in the LoadMetrics until the next autoscaling iteration.
This PR shifts the removal of IPs to occur after terminating idle and dead nodes, so that we won't have those nodes shown in the summary report.
Related issue number
Closes #52198 (comment)
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.