Skip to content

Conversation

@aslonnie
Copy link
Collaborator

@aslonnie aslonnie commented Nov 3, 2025

getting ready for start releasing python 3.13 images

getting ready for start releasing python 3.13 images

Signed-off-by: Lonnie Liu <[email protected]>
@aslonnie aslonnie requested a review from elliot-barn November 3, 2025 01:09
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request begins the process of building images for Python 3.13 by adding it to the build matrix in the Buildkite pipeline configuration. The changes are straightforward and correctly enable the new Python version for various build jobs. I have included one suggestion to enhance the maintainability of the pipeline configuration by using YAML anchors to define the Python version list, which will simplify future updates.

Comment on lines 12 to +15
- "3.10"
- "3.11"
- "3.12"
- "3.13"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and reduce redundancy, consider defining the list of Python versions once using a YAML anchor and then reusing it across the different build steps. This will make it easier and less error-prone to manage Python versions in the future.

For example, you could define an anchor at the top of your file (or in a suitable shared location):

.python-versions: &python-versions
  - "3.10"
  - "3.11"
  - "3.12"
  - "3.13"

And then reference it in your matrices:

# In the matrix definition
python: *python-versions

This refactoring would need to be applied to all places where this list of Python versions is duplicated.

@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Nov 3, 2025
@ray-gardener ray-gardener bot added core Issues that should be addressed in Ray Core devprod labels Nov 3, 2025
@aslonnie aslonnie removed the go add ONLY when ready to merge, run all tests label Nov 3, 2025
@aslonnie
Copy link
Collaborator Author

aslonnie commented Nov 3, 2025

seems that we need dependency set for image building to work.

@aslonnie aslonnie marked this pull request as draft November 3, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issues that should be addressed in Ray Core devprod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants