update extension GitHub Profile #17906
Merged
+21
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raycastbot
added
extension fix / improvement
|
Thank you for the update! 🎉 Due to our current reduced availability, the initial review may take up to 10-15 business days |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR updates the GitHub Profile extension to better handle cases where users haven't provided a GitHub token, adding mock data alerts and improving error handling.
- Inconsistency in
/extensions/github-profile/README.md: States token is required but code works without it - documentation should be updated to reflect actual behavior - Added warning toast in
/extensions/github-profile/src/api/github.tswhen using mock contribution data - REST API endpoints (profile and repos) already work without token despite roadmap item suggesting otherwise
- Consider removing "token required" warning from README since it's now optional
- GraphQL error handling in
fetchContributionData()could be more specific about failure reasons
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Hi @ridemountainpig , what do you think? :) |
|
As in the description, now let's require users to input a token as a safe choice. |
ridemountainpig
approved these changes
Mar 17, 2025
pernielsentikaer
approved these changes
Mar 17, 2025
|
Published to the Raycast Store: |
|
🎉 🎉 🎉 We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix issue #17904
TLDR: we don't force users to provide a token but show the alerts when mock data is returned, as a fix.Since REST API can be used to fetch even without a token, which has not been implemented yet.
Now we change GitHub token to required field, as a safe choice.
Screencast
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare located outside the metadata folder if they were not generated with our metadata tool