Conversation
|
@LockeAG is attempting to deploy a commit to the Raycast Team on Vercel. A member of the Team first needs to authorize it. |
a04ca03 to
815810d
Compare
There was a problem hiding this comment.
Pull request overview
Adds a new dark theme entry to the theme gallery for the Tokyo Night Storm variant, intended to complement the existing folke/Tokyo Night theme.
Changes:
- Added a new theme JSON file under
app/(navigation)/themes/themes/lockeag/for “Tokyo Night Storm”. - Defined the theme’s color palette and metadata (appearance, author, version).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "backgroundSecondary": "#1D202F", | ||
| "text": "#C0CAF5", | ||
| "selection": "#7AA2F7", | ||
| "loader": "#FF9E64", |
There was a problem hiding this comment.
The values for backgroundSecondary, selection, and loader don’t match the PR’s stated “Color reference” table / “All colors are taken directly from the upstream Storm palette” claim. Currently this file uses backgroundSecondary: #1D202F, selection: #7AA2F7, and loader: #FF9E64, while the PR description lists #1F2335, #364A82, and #7AA2F7 respectively. Please either update these color values to the intended Storm palette mappings or adjust the PR description so it accurately reflects the shipped theme.
Adds the Storm variant of Tokyo Night to the gallery, complementing the existing
folke/Tokyo Nightentry with the second most popular variant fromfolke/tokyonight.nvim.Why a separate entry
folke/Tokyo Nightships the canonical Night flavor (#1A1B26-family backgrounds). Storm is a meaningfully distinct variant — slightly lighter, slightly cooler — with its own dedicated palette in the upstream tokyonight.nvim repo. Both flavors have their fans, and following the precedent ofluisFilipePT/snow-storm.jsonandluisFilipePT/polar-night.json(Nord variants published alongside other Nord work), this lives under its own author folder rather than presuming to extendfolke/.All colors are taken directly from the upstream
tokyonight.nvimStorm palette. No invented values.Color reference
background#24283BbgbackgroundSecondary#1F2335bg_darktext#C0CAF5fgselection#364A82loader#7AA2F7bluered#F7768Eredorange#FF9E64orangeyellow#E0AF68yellowgreen#9ECE6Agreenblue#7AA2F7bluepurple#7DCFFFcyan*magenta#BB9AF7magenta(the iconic TN lavender)* The Tokyo Night palette has two purples (
#9D7CD8and#BB9AF7) sharing nearly the same hue (~261°). Mapping both into Raycast'spurpleandmagentaaccent slots collapses the categorical distinction at small sizes. Substituting Tokyo Night'scyan(#7DCFFF) into thepurpleslot keeps every color canonical to the upstream palette while restoring the spread that the accent system expects. The same convention is used byayu-mirage-owl.json, which puts a cyan in theblueslot.