[rcore_desktop_glfw.c] fix: make sure that GLFW uses RL_*ALLOC macros #4777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raylib allows for providing custom allocators via macros. GLFW supports this too, but via function pointers. Make sure that GLFW uses those Raylib macros, by wrapping them in function calls and setting them up inside of InitPlatform(). This is possible because of glfwInitAllocator() and GLFWallocator. Fixes: raysan5#4776 Relates-to: raysan5#4751
sleeptightAnsiC
changed the title
|
@sleeptightAnsiC thanks for this review! That TODO has been there for a long time! 👍😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raylib allows for providing custom allocators via macros. GLFW supports this too, but via function pointers. Let's make sure that GLFW uses those Raylib macros, by wrapping them in function calls and setting them up inside of InitPlatform(). This is possible because of glfwInitAllocator() and GLFWallocator. (see linked issue for more context)
I hope that code notes speak for itself but let me know what do you think, and if this is the correct approach or not.
Tested on x86_64 Linux with GNU Make and Cmake, with GCC and TCC, by compiling and running some examples.
Reference: https://www.glfw.org/docs/latest/intro_guide.html#init_allocator
Fixes: #4776
Relates-to: #4751