Skip to content

Conversation

@Yashk767
Copy link
Contributor

@Yashk767 Yashk767 commented Mar 20, 2025

User description

Description

We have been using the public RPC https://rpc.ankr.com/eth for a few tests. This RPC was active until last week but now appears to be down, causing test failures and preventing the CI workflow from passing.

Fixes https://linear.app/interstellar-research/issue/RAZ-1263

Solution

This PR updates the public RPC used in certain tests to ensure that the CI workflow passes successfully.


PR Type

Bug fix, Tests


Description

  • Updated deprecated public RPC URLs in test cases.

  • Replaced https://rpc.ankr.com/eth with https://ethereum-rpc.publicnode.com.

  • Ensured CI workflow passes by fixing test failures.


Changes walkthrough 📝

Relevant files
Bug fix
asset_test.go
Replace deprecated RPC URL in test cases                                 

utils/asset_test.go

  • Replaced deprecated RPC URL https://rpc.ankr.com/eth with
    https://ethereum-rpc.publicnode.com.
  • Updated multiple test cases to use the new RPC URL.
  • Ensured compatibility with the new RPC endpoint for POST requests.
  • +5/-5     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link

    @astronaut-aldrin astronaut-aldrin bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Error during code review: 'NoneType' object is not subscriptable

    @qodo-merge-for-open-source
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link

    @astronaut-aldrin astronaut-aldrin bot left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Error during code review: 'NoneType' object is not subscriptable

    @qodo-merge-for-open-source
    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @Yashk767 Yashk767 merged commit e0a41d9 into main Mar 20, 2025
    5 checks passed
    @Yashk767 Yashk767 deleted the yash/raz-1263-tests-fail-due-to-ankr-public-rpc-deprecation branch March 21, 2025 05:32
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    5 participants