Magic integration latest #524
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… customer email in notes
Added COD fee support in magento order
…o add_magic_integration_param
…ay-magento into magic_integration_latest
…ay-magento into add_magic_integration_param
Added magic-integration param
…o magic_integration_latest
…ay-magento into magic_integration_latest
lbajsarowicz
suggested changes
Aug 2, 2025
| @@ -0,0 +1,26 @@ | |||
| <?php | |||
| use Magento\Sales\Block\Adminhtml\Order\Totals as MagentoOrderTotals; | ||
| use Magento\Framework\DataObject; | ||
|
|
||
| class Totals extends MagentoOrderTotals |
There was a problem hiding this comment.
You should avoid inheritance.
In this specific case, you should use Magento built-in composition for adding custom Totals.
| @@ -0,0 +1,370 @@ | |||
| <?php | |||
|
|
||
| namespace Razorpay\Magento\Controller\OneClick; | ||
|
|
||
| use Magento\Framework\App\Action\Action; |
| /** | ||
| * @var Http | ||
| */ | ||
| protected $request; |
There was a problem hiding this comment.
All non-public properties should be private
Comment on lines
+56
to
+58
| const COD = 'cashondelivery'; | ||
| const RAZORPAY = 'razorpay'; | ||
| const STATE_PENDING_PAYMENT = 'pending_payment'; |
There was a problem hiding this comment.
constshould be at the top of the class- And have their visibility
public/private
|
|
||
| $orderPlacement = false; | ||
|
|
||
| try { |
There was a problem hiding this comment.
Nested try ... catch significantly increases the cyclomatic complexity, making it difficult to troubleshoot / debug
| @@ -0,0 +1,98 @@ | |||
| <!-- | |||
There was a problem hiding this comment.
- Override in Payment Method module is really bad idea,
- Additionally -- You should not include outdated Magento copyright message.
| @@ -0,0 +1,45 @@ | |||
| <?php | |||
There was a problem hiding this comment.
You should never use ObjectManager directly.
Instead, inject ViewModel to the view.
| @@ -0,0 +1,33 @@ | |||
| <?php | |||
|
|
|||
| $objectManager = getObjectManager(); | |||
There was a problem hiding this comment.
You should never use ObjectManager directly.
Instead, use view model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note :- Please follow the below points while attaching test cases document link below:
- If label
Testedis added then test cases document URL is mandatory.- Link added should be a valid URL and accessible throughout the org.
- If the branch name contains hotfix / revert by default the BVT workflow check will pass.