Skip to content

Conversation

@kayvank
Copy link
Contributor

@kayvank kayvank commented Oct 29, 2018

feat: impl Search Asset By Metadata.
Version 1 of search feature implemented at the MIT Open Music Legal Hackathon in Boston.
Pull request supports search by asset id only
Future work:

  • Search root level attributes of metadata

@kayvank
Copy link
Contributor Author

kayvank commented Oct 29, 2018

remaining work:

  • unit tests for the serach
  • unit tests for the new http route
  • unit test for valid/invalid search criteria

@@ -0,0 +1,4 @@
curl --header "Content-Type: application/json" \
--request POST \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a search should use GET.

@dazzaji
Copy link

dazzaji commented Nov 12, 2018

So glad you were able to make some progress!! Is there a demo of this (like a screenshare video or such) of this somewhere I could take a look at? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants