-
Notifications
You must be signed in to change notification settings - Fork 339
Fix Buy/Sell Logic, Update IDL, and Add Missing bn.js Dependency #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
LGTM! |
|
Getting this error when attempting to create a token using this MR: |
same here. Any fix for this? |
|
I changed the files that were changed in this commit, but I seem to run into this issue |
|
@LightYagami200 @Storryy Details% npm run exampleInitial test account balance: 🔧 GlobalAccount: 📤 Create & Buy TX: 📈 Bonding curve after create & buy: 💰 SPL Balance after buy: 3576.654744 📈 Bonding curve after buy: 💸 Sell:
📤 Sell TX: Final test account balance: 0.031397181 SOL 📉 Bonding curve after sell: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buy / sell working.
I did not try the create
|
I'm going to test and merge thank you! |
hey? its been a while |
This pull request addresses compatibility and functionality issues introduced by the recent Pump.fun IDL update. The following changes have been made:
Updated buy, sell, and createAndBuy functions to align with the updated IDL structure.
Synchronized project interfaces with the latest Pump.fun IDL to ensure seamless program interaction.
Added the missing bn.js dependency required for BigNumber operations.