Drop resolving listener file descriptor by reflecting private struct fields. #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fields. Instead we duplicate listener file descriptor, which handles closeOnExec syscalls
|
Thanks a lot for this PR. It saved me a lot of debug time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop resolving listener file descriptor by reflecting private struct fields. Instead we duplicate listener file descriptor, which handles closeOnExec syscalls.
The current implementation uses reflect package, and is prone to break (actually as of go 1.9 it WILL break, because the
netFDstruct fields have been moved around and sysfd field does not exist anymore, and is reachable instead bypfd poll.FDfield).