-
Notifications
You must be signed in to change notification settings - Fork 35
linux_distribution in platform is deprecated in Python 3.5 and removed in Python 3.8 #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
linux_distribution in platform is deprecated in Python 3.5 and removed in Python 3.8 #11
Conversation
…inux_distribution for Linux systems with the human readable output of platform(). Example Linux USER_AGENT: `python-ipify/1.0.0 python/3.8.3 Linux/Linux-5.6.16-1-MANJARO-x86_64-with-glibc2.2.5` Update .gitignore to exclude JetBrains workspace junk.
|
If you have a different string you'd like pulled into the USER_AGENT just let me know. |
|
@timotree, @akasto, @yearski, @adrian-soto |
|
@Tridacnid No, I haven't bothered since it's much easier to just use requests and make the request without an additional dependency |
|
Yep, makes sense. |
Since ipify.org is owned/mantained by @rdegges, I didn't want to make any assumptions about how he might want to USER_AGENT string to appear with this client for any logging he might care to do on the server. Obviously it's a very minor point so I just patch the files as it's just a few lines of code. |
|
I emailed the developer at the email address listed here asking if he wouldn't mind reviewing the open pull requests. Fingers crossed. |
|
Hey all, this project is now owned by WhoisXML -- they have a developer who works on this. |
|
@rdegges , do you have a contact for the new maintainer? Everything on PyPI, github, and ipify still points to you. Which of the three that have been mentioned does WhoisXML own and when did the transfer of responsibility happen? |
|
I have forked and updated this package and released it on PyPi as |
|
@rdegges could you update the website to include ipify2 in the list of module? It would be most useful for anyone who needs to do use it, not look in the responses of a pull request of the broken one that is currently linked. |
|
i am creating new module with syncronous asyncronous and cli named PyIpify |
linux_distribution in platform is deprecated in Python 3.5 and removed in Python 3.8
Remove linux_distribution import. Replace the call to linux_distribution for Linux systems with the human readable output of platform().
Example Linux USER_AGENT:
python-ipify/1.0.0 python/3.8.3 Linux/Linux-5.6.16-1-MANJARO-x86_64-with-glibc2.2.5orpython-ipify/1.0.0 python/2.7.18 Linux/Linux-5.6.16-1-MANJARO-x86_64-with-glibc2.2.5Update .gitignore to exclude JetBrains workspace junk.
Tested on Manjaro with Python 3.8 and Python 2.7