Skip to content

Conversation

@Tridacnid
Copy link

linux_distribution in platform is deprecated in Python 3.5 and removed in Python 3.8

Remove linux_distribution import. Replace the call to linux_distribution for Linux systems with the human readable output of platform().

Example Linux USER_AGENT: python-ipify/1.0.0 python/3.8.3 Linux/Linux-5.6.16-1-MANJARO-x86_64-with-glibc2.2.5 or python-ipify/1.0.0 python/2.7.18 Linux/Linux-5.6.16-1-MANJARO-x86_64-with-glibc2.2.5

Update .gitignore to exclude JetBrains workspace junk.

Tested on Manjaro with Python 3.8 and Python 2.7

…inux_distribution for Linux systems with the human readable output of platform().

Example Linux USER_AGENT: `python-ipify/1.0.0 python/3.8.3 Linux/Linux-5.6.16-1-MANJARO-x86_64-with-glibc2.2.5`

Update .gitignore to exclude JetBrains workspace junk.
@Tridacnid
Copy link
Author

If you have a different string you'd like pulled into the USER_AGENT just let me know.

@Tridacnid
Copy link
Author

Wow, I see there are multiple pulls open for this (#7, #8, #9, #10).

@Tridacnid
Copy link
Author

@timotree, @akasto, @yearski, @adrian-soto
Have any of you forked this project and published it as an alternative? It uses the UNLICENSE so there shouldn't be any problem putting out a clone on Pypi. Doesn't seem like it's actively maintained if some of these PRs are open from 6+ months ago.

@timotree
Copy link

@Tridacnid No, I haven't bothered since it's much easier to just use requests and make the request without an additional dependency

@Tridacnid
Copy link
Author

Yep, makes sense.

@yearski
Copy link

yearski commented Jun 20, 2020

@timotree, @akasto, @yearski, @adrian-soto
Have any of you forked this project and published it as an alternative?

Since ipify.org is owned/mantained by @rdegges, I didn't want to make any assumptions about how he might want to USER_AGENT string to appear with this client for any logging he might care to do on the server. Obviously it's a very minor point so I just patch the files as it's just a few lines of code.

@solintllc-robert
Copy link

I emailed the developer at the email address listed here asking if he wouldn't mind reviewing the open pull requests. Fingers crossed.

@rdegges
Copy link
Owner

rdegges commented Aug 18, 2020

Hey all, this project is now owned by WhoisXML -- they have a developer who works on this.

@mblahay
Copy link

mblahay commented Nov 17, 2020

@rdegges , do you have a contact for the new maintainer? Everything on PyPI, github, and ipify still points to you. Which of the three that have been mentioned does WhoisXML own and when did the transfer of responsibility happen?

@nwithan8
Copy link

nwithan8 commented Dec 9, 2020

I have forked and updated this package and released it on PyPi as ipify2: https://pypi.org/project/ipify2/

@LastedApple3
Copy link

@rdegges could you update the website to include ipify2 in the list of module? It would be most useful for anyone who needs to do use it, not look in the responses of a pull request of the broken one that is currently linked.

@SigireddyBalasai
Copy link

i am creating new module with syncronous asyncronous and cli named PyIpify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants