WIP: Save json with uri hint #1383
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 3, 2024 20:53
- Without uriHint, referenceUri is contained into saved json file. - It seems the current jsonwriter only contains all the resolved bodies into one file, so referenceUri seems unnecessary. - In addition, if saved referenceUri is unnecessarily contained, - When we load it on openrave, warning message is shown. - Other model loader software cannot load it because referenced file does not exist. - I added noUriHint option. It's unnecessary right now, but in future, once we support file saving preserving the reference files, it might be necessary.
Owner
|
Changing default option like this could affect a lot... we should have ziyan and yoshiki comment on this. |
Collaborator
Author
thanks for your comment!
Thanks! p.s. It looks some tests are failing and needs to investigate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
referenceUriis contained into saved json file.jsonwriter.cpponly contains all the resolved bodies into one file, soreferenceUriseems unnecessary.referenceUriis unnecessarily contained in the file,jsonreader.cpp, warning message is shown.noUriHintoption just in case. It's unnecessary right now, but in future, once we support file saving preserving the reference files, it might be necessary.