-
Notifications
You must be signed in to change notification settings - Fork 355
Fix potential bad memory access at polyroots function #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: production
Are you sure you want to change the base?
Conversation
|
I added |
|
bumped "minor" version (instead of patch version) / added changelog. |
compilation failed, taking a look. |
This reverts commit 8230e65.
With an older boost version, compiler did not catch the false positive out of bounds. I think it's okay without |
|
@yoshikikanemoto could you review this MR? |
|
@MiraiHattori why is minor version bump? looks like there are no ABI breaking changes? do you have unit tests that produce out-of-bounds access? |
I reverted to patch version bump since there was no interface changes. I don't have a unit test to reproduce the issue so far, let me make one. |
This PR fixes the attached compiler warning. Potentially if the input of those functions are per-joint linearly changing trajectories, then there may be segmentation fault.
Details
D=1, then thisroots[1]is out of bound.openrave/include/openrave/mathextra.h
Line 1233 in 7fdb0b5
D=1. if the system accidentally hits it, segmentation fault will happenopenrave/include/openrave/mathextra.h
Lines 1467 to 1470 in 7fdb0b5