Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate from ora to nanospinner #2640

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wojtekmaj
Copy link
Contributor

@wojtekmaj wojtekmaj commented Mar 28, 2025

Summary

This PR migrates the entire repository from ora to nanospinner. nanospinner has a 17.5 TIMES smaller footprint [1], [2], and has just one dependency as opposed to 17.

Note that ora is not removed from this repo's dependencies, as it remains a dependency of inquirer. However, it's removed from package dependencies, resulting in faster install and smaller footprint for the end users.

Test Plan

To be frank, I relied on TypeScript alone for this change and I don't know this project well enough to test it, especially the Android part. nanospinner is almost a drop-in replacement for ora so I don't expect major issues though.

Checklist

  • Documentation is up to date.
  • Follows commit message convention described in CONTRIBUTING.md.
  • For functional changes, my test plan has linked these CLI changes into a local react-native checkout (instructions).

@github-actions github-actions bot added the docs Documentation change label Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant