Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update props of avatar component #28

Merged
merged 2 commits into from
Mar 11, 2021
Merged

fix: update props of avatar component #28

merged 2 commits into from
Mar 11, 2021

Conversation

sachdeva-shrey
Copy link
Contributor

@sachdeva-shrey sachdeva-shrey commented Mar 10, 2021 •
edited
Loading

Signed-off-by: sachdeva-shrey [email protected]

Fixes # #19

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Changes

  • Remove deprecated prop (showAccessory and onAccessoryPress)
  • Add default backgroundColor (#BDBDBD) to containerStyle

Screenshot

Screenshot from 2021-03-10 23-10-46

@netlify
Copy link

netlify bot commented Mar 10, 2021 •
edited
Loading

Deploy preview for rne-playground ready!

Built with commit 767a685

https://deploy-preview-28--rne-playground.netlify.app

@sachdeva-shrey
fix: remove showAccessory prop
767a685 
Signed-off-by: sachdeva-shrey <[email protected]>
tewarig
tewarig reviewed Mar 11, 2021
View reviewed changes
Copy link
Contributor

@tewarig tewarig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@pranshuchittora
Copy link
Member

LGTM 👍
Thanks

@pranshuchittora pranshuchittora merged commit 0c5cc65 into react-native-elements:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tewarig tewarig tewarig left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sachdeva-shrey @pranshuchittora @tewarig