Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: made button and avatar component functional #42

Closed
wants to merge 1 commit into from

Conversation

nlok5923
Copy link
Contributor

fixes part of: #3
changes:

  • made avatar and button component functional

@netlify
Copy link

netlify bot commented Mar 12, 2021

Deploy preview for rne-playground ready!

Built with commit e6b3062

https://deploy-preview-42--rne-playground.netlify.app

@Devesh21700Kumar
Copy link

hey, i've already done this in my PR earlier.. so it might just get repititive

@nlok5923
Copy link
Contributor Author

But currently this change hadn't reflected in codebase also I hadn't seen any or with these changes that's why I made a pr.

@Devesh21700Kumar
Copy link

But currently this change hadn't reflected in codebase also I hadn't seen any or with these changes that's why I made a pr.

yeah my PR had some stuff regarding relative imports so it was held on review.. it was to be merged

Copy link
Contributor

@tewarig tewarig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to be quite similar to #31

@Devesh21700Kumar
Copy link

this seems to be quite similar to #31

yes exactly..

@nlok5923 nlok5923 closed this Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants