Skip to content

Chore(warnings): Rectification of code by removing all (jsx-A11y) warnings (closed due to Conflict) #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Chore(warnings): Rectification of code by removing all (jsx-A11y) warnings (closed due to Conflict) #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c08e3ec
fix: Drawer navigation bug complete fix made
Uyadav207 Mar 10, 2021
330bf47
fix: Drawer navigation bug complete fix made
Uyadav207 Mar 10, 2021
90ffade
fix: modified bug created by previous fix
Uyadav207 Mar 10, 2021
787a0b9
chore(warnings): Rectification of code by removing all (jsx-A11y) war…
Uyadav207 Mar 12, 2021
cd28e20
Merge branch 'master' into chores/warnings
Uyadav207 Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/components/Footer/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,25 @@ function Footer() {
<Grid container spacing={5} justify="center">
<Grid item xs={12} md={6} lg={4}>
<Typography variant="h4" style={{ marginBottom: 10 }}>
Playground 🚀
Playground <span role="img" aria-label="Playground">🚀</span>
</Typography>

<Divider />

<a
href="https://github.com/react-native-elements/playground"
target="_blank"
rel="noopener noreferrer"
>
<Typography>GitHub Repositoy</Typography>
</a>

<a href="https://reactnativeelements.com/" target="_blank">
<a href="https://reactnativeelements.com/" target="_blank" rel="noopener noreferrer">
<Typography>Official Docs</Typography>
</a>
<br />

<a href="https://www.netlify.com">
<a href="https://www.netlify.com" target="_blank" rel="noopener noreferrer">
<img
src="https://www.netlify.com/img/global/badges/netlify-color-accent.svg"
alt="Deploys by Netlify"
Expand All @@ -46,6 +47,7 @@ function Footer() {
<a
href="https://github.com/react-native-elements/react-native-elements/"
target="_blank"
rel="noopener noreferrer"
>
<Typography variant="h6">React Native Elements</Typography>
<Typography
Expand All @@ -56,8 +58,9 @@ function Footer() {
</Typography>

<img
src={require("../../assets/RNE_Logo.png")}
className={styles.footer_product_img}
src={require("../../assets/RNE_Logo.png")}
alt="React-Native-Elements"
/>

<img
Expand Down
4 changes: 2 additions & 2 deletions src/containers/Drawer/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ function ResponsiveDrawer(props) {
<div style={{ padding: "0.5rem" }}>
<Link to="/">
<Typography style={{ fontWeight: 100 }} variant="h5">
Playground 🚀
Playground <span role="img" aria-label="Playground">🚀</span>
</Typography>
</Link>
</div>
Expand Down Expand Up @@ -121,7 +121,7 @@ function ResponsiveDrawer(props) {
</Typography>
</Link>
<div style={{ marginLeft: "auto" }}>
<a href="https://reactnativeelements.com/" target="_blank">
<a href="https://reactnativeelements.com/" target="_blank" rel="noopener noreferrer">
<Button color="inherit">Docs</Button>
</a>
<IconButton
Expand Down
2 changes: 1 addition & 1 deletion src/containers/Navigation/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ export default function App() {
})}
<Route exact path="/explore">
<Helmet>
<title>Explore | Playground 🚀 - React Native Elements</title>
<title>Explore | Playground <span role="img" aria-label="Playground">🚀</span> - React Native Elements</title>
</Helmet>
<ExplorePage />
</Route>
Expand Down
3 changes: 2 additions & 1 deletion src/pages/home/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ function HomePage() {
<div style={{ width: "100%", textAlign: "center", marginBottom: "2rem" }}>
<Link to="/explore">
<Button variant="outlined" color="secondary">
<Typography variant="h6">Explore Now 🌇</Typography>
<Typography variant="h6">Explore Now <span role="img" aria-label="explore" >🌇</span></Typography>
</Button>
</Link>
</div>
Expand Down Expand Up @@ -94,6 +94,7 @@ const FeatureCard = (props) => {
display: "flex",
}}
src={props.banner}
alt="Home"
/>
<div style={{ bottom: 0, marginTop: "1rem" }}>
<Typography variant="h5">{props.title}</Typography>
Expand Down