-
Notifications
You must be signed in to change notification settings - Fork 108
feat: add option to disable horizontal swiping when scroll is true. #624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mickael-menu
merged 5 commits into
readium:develop
from
bookshop-org:feat/disable-horiz-swipe
Mar 24, 2025
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2ce5fb2
feat: add option to disable horizontal swiping when settings.scroll i…
tm-bookshop 4c817e0
PR comments
tm-bookshop 7608334
rename
tm-bookshop a396ed1
Merge branch 'develop' into feat/disable-horiz-swipe
tm-bookshop 5298e91
apply diff
tm-bookshop File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -111,11 +111,13 @@ internal open class R2BasicWebView(context: Context, attrs: AttributeSet) : WebV | |
var resourceUrl: AbsoluteUrl? = null | ||
|
||
internal val scrollModeFlow = MutableStateFlow(false) | ||
internal val scrollModeDisableSwipePaginationFlow = MutableStateFlow(false) | ||
|
||
/** Indicates that a user text selection is active. */ | ||
internal var isSelecting = false | ||
|
||
val scrollMode: Boolean get() = scrollModeFlow.value | ||
private val scrollModeDisableSwipePagination: Boolean get() = this.scrollModeDisableSwipePaginationFlow.value | ||
|
||
var callback: OnOverScrolledCallback? = null | ||
|
||
|
@@ -213,6 +215,9 @@ internal open class R2BasicWebView(context: Context, attrs: AttributeSet) : WebV | |
} | ||
|
||
when { | ||
// If the user is in scrollMode and has disabled swipe pagination, do nothing. | ||
scrollMode && [email protected] -> {} | ||
|
||
scrollMode -> | ||
goRight(jump = true) | ||
|
||
|
@@ -244,6 +249,9 @@ internal open class R2BasicWebView(context: Context, attrs: AttributeSet) : WebV | |
} | ||
|
||
when { | ||
// If the user is in scrollMode and has disabled swipe pagination, do nothing. | ||
scrollMode && [email protected] -> {} | ||
|
||
scrollMode -> | ||
goLeft(jump = true) | ||
|
||
|
@@ -392,7 +400,6 @@ internal open class R2BasicWebView(context: Context, attrs: AttributeSet) : WebV | |
fun onDragEnd(eventJson: String): Boolean { | ||
val event = DragEvent.fromJSON(eventJson)?.takeIf { it.isValid } | ||
?: return false | ||
|
||
return runBlocking(uiScope.coroutineContext) { listener?.onDragEnd(event) ?: false } | ||
} | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.