Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified XmlParser to correctly parse CDATA. #633

Merged
merged 3 commits into from
Mar 25, 2025
Merged

Modified XmlParser to correctly parse CDATA. #633

merged 3 commits into from
Mar 25, 2025

Conversation

erkasraim
Copy link
Contributor

#627

I have addressed the issue I previously created.
Fixed a bug where text was incorrectly parsed when CDATA was present in the XML file.

qnga
qnga approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@qnga qnga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@mickael-menu
Copy link
Member

You can run make format from the root of the repository to fix the formatting automatically.

@qnga
Copy link
Member

qnga commented Mar 25, 2025

I've done it.

@qnga qnga merged commit 00ca5cd into readium:develop Mar 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qnga qnga qnga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erkasraim @mickael-menu @qnga