Add sorting and filtering of TTS voices #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds filtering and sorting capabilities for TTS voices, introducing two new extension methods to help manage and organize available voices by language, region, quality, and gender.
- Adds
[TTSVoice].filterByLanguage(_:)to filter voices by language with support for both base language and region-specific filtering - Adds
[TTSVoice].sorted()to sort voices by multiple criteria: region priority, quality, gender, and name - Updates
TTSVoice.Qualityenum to includelowerandhighercases and changesnamefrom optional to non-optional
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Sources/Navigator/TTS/TTSVoice.swift | Moves TTSVoice to dedicated file and adds filtering and sorting extension methods |
| Sources/Navigator/TTS/TTSEngine.swift | Removes TTSVoice definition (moved to separate file) |
| Sources/Shared/Toolkit/Language.swift | Adds Region struct to support region-based operations |
| Tests/NavigatorTests/TTS/TTSVoiceTests.swift | Comprehensive test suite covering filtering, sorting, and edge cases |
| CHANGELOG.md | Documents the new public API additions |
Comments suppressed due to low confidence (1)
Sources/Navigator/TTS/TTSVoice.swift:1
- The mapping from AVSpeechSynthesisVoice.quality to TTSVoice.Quality is incomplete. The new
lowerandhigherquality cases are never assigned. Consider mapping.premiumto.higherinstead of.high, and review whether.defaultshould map to.lowor.lowerinstead of.mediumfor better utilization of the new quality levels.
//
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…pact/super-compact identifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Navigator
[TTSVoice].filterByLanguage(_:)to filter TTS voices by language and region.[TTSVoice].sorted()to sort TTS voices by region, quality, and gender.Changed
Navigator
PublicationSpeechSynthesizerAPI, as they are not a good fit to read publications.