-
Notifications
You must be signed in to change notification settings - Fork 19
Support for accessibility in shared models #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can be a string or an array of strings per https://readium.org/webpub-manifest/contexts/default/#accessibility-metadata
@chocolatkey I am not anticipating changes myself so I’m marking this as ready to review so that another pair of eyes can see whether this is acceptable or whether we want to do some things in a smarter way. As a recap, this adds It also handles the Accessibility Metadata Display Guide, in a way that should be consistent with Swift – so statements with an For localization, I had to design something around thorium-locales. Basically:
It is kind of straightforward as classes are just mapping statements to conditions but of course there may be room for improvements and/or details that could be polished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The circular dependency on thorium for the locales data is a bit unusual and couples it strongly to the EDRLab repo, but it works
return this.uri; | ||
} | ||
|
||
public static readonly EPUB_A11Y_10_WCAG_20_A = new AccessibilityProfile('http://www.idpf.org/epub/a11y/accessibility-20170105.html#wcag-a'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to add comments to these for intellisense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point will do
return this.value; | ||
} | ||
|
||
public static readonly AUDITORY = new AccessMode('auditory'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same goes for here (and below), it might be nice to add comments to these for intellisense
} | ||
|
||
public static readonly NONE = new Feature('none'); | ||
public static readonly ANNOTATIONS = new Feature('annotations'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HadrienGardeur should I be adding the missing features to the go-toolkit?
public static readonly EAA_DISPROPORTIONATE_BURDEN = new Exemption('eaa-disproportionate-burden'); | ||
public static readonly EAA_FUNDAMENTAL_ALTERATION = new Exemption('eaa-fundamental-alteration'); | ||
public static readonly EAA_MICROENTERPRISE = new Exemption('eaa-microenterprise'); | ||
public static readonly EAA_TECHNICAL_IMPOSSIBILITY = new Exemption('eaa-technical-impossibility'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also not in the go-toolkit @HadrienGardeur
This adds support for
accessibility
inmetadata
of Shared Models (RWPM doc).Display Guide to follow