Skip to content

Build: obfuscate private variables #12366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 30, 2025
Merged

Conversation

humitos
Copy link
Member

@humitos humitos commented Jul 28, 2025

Replace the value of private variables with the first 4 chars of it and ****. This is a protection to avoid leaking private variables by mistake.

The same pattern is used in the dashboard when listing these variables.

Closes https://github.com/readthedocs/readthedocs-corporate/issues/2004

Replace the value of private variables with the first 4 chars of it and `****`.
This is a protection to avoid leaking private variables by mistake.

The same pattern is used in the dashboard when listing these variables.

Closes readthedocs/readthedocs-corporate#2004
@humitos humitos requested a review from a team as a code owner July 28, 2025 11:10
@humitos humitos requested a review from stsewd July 28, 2025 11:10
@humitos humitos enabled auto-merge (squash) July 30, 2025 08:28
@humitos humitos merged commit 8e43dba into main Jul 30, 2025
4 checks passed
@humitos humitos deleted the humitos/build-obfuscate-envvars branch July 30, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants