-
Notifications
You must be signed in to change notification settings - Fork 7
Add comparison index page. #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This cleans up the website footer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me.
I like it. The whole card is clickable now and it moves a little when you hover, which is a good visual differentiator 👍🏼 The inline CSS is a problem, tho, I'm not sure why you weren't able to use a class and put it outside the HTML. I'm sure I had a similar problem in other places already and I fixed it somehow. Maybe you can check the other files. |
Found it! Yeah, actually, it's in the index file in https://github.com/readthedocs/site-community/blob/05cad1a501968b3ecabcc7450d2fff972bb470c3/content/includes/users-sphinx.html#L4-L59 he, it seems the solution was to make all the images the same height 😉 and skip using CSS... Very smart 🧠 movement, haha |
Yup, all images should be edited to be the same proportions going in. |
<div class="ui basic padded segment" style="height: 100px; display: flex; align-items: center; justify-content: center;"> | ||
<div class="ui small centered image"> | ||
<img src="{{ logo_url }}" alt="{{ logo_alt }}" style="max-height: 50px; width: auto;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should instead edit the images to get similar proportions and alignment.
.ui.small.image
already controls the size and centering of the image, inline styles or a statically sized segment shouldn't be used to dictate this.
This cleans up the website footer.
FIxes #234
📚 Documentation preview 📚: https://readthedocs-about--350.org.readthedocs.build/