Produce uniformly-distributed permutation in ~jimble #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlai
reviewed
Oct 15, 2020
|
|
||
| '~jimble': function(event) { | ||
| event.reply(event.params[1].split('').sort(function() { | ||
| return (Math.round(Math.random()) - 0.5); |
There was a problem hiding this comment.
This deletion calls Math.random once fewer...
adlai
approved these changes
Oct 15, 2020
| var jimbled = new Array(word.length); | ||
| for (var i = 0; i < word.length; i++) { | ||
| do { | ||
| rnd = Math.floor(Math.random()*word.length); |
There was a problem hiding this comment.
... and this line restores the original code's entropy consumption fingerprint.
unsolicited ACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of ~jimble uses a sorting function with a random comparison function. This does not create a uniform distribution of permutations when used with many (including the default) sorting algorithms.
This patch produces a uniformly-distributed permutation of the word by choosing a random, unused letter from the original word for each position in the jimbled word.