Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCORE-2253 Redirected user authenticated app requests cause user to be logged out and location is not updated #8011

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
aa34635
Removed redirect tests
Aug 23, 2024
fd52bb1
Removed one more location redirect test case
Aug 23, 2024
3a9c663
Removed 301/308 redirection support from App
Aug 23, 2024
519a71e
Updated changelog
Aug 23, 2024
8a753e5
Updates from review
Aug 27, 2024
d5c2800
Merge branch 'master' of github.com:realm/realm-core into mwb/remove-…
Aug 27, 2024
3cc2261
Merge branch 'mwb/remove-308-tests' of github.com:realm/realm-core in…
Aug 27, 2024
aba04c7
Updated redirect server to support App request redirects and created …
Aug 28, 2024
e0a971d
Added test to verify http redirects using CURL to handle the redirect…
Aug 29, 2024
420d56a
Added test sections and print error on create_user_and_login() failure
Aug 29, 2024
a06e319
Updated changelog; some cleanup; moving redir_server tool to separate PR
Aug 29, 2024
69c232c
Addressed some build and test failures
Aug 30, 2024
3c0cd07
More minor updates to fix build and test failures
Aug 30, 2024
4e8484e
Merge branch 'master' of github.com:realm/realm-core into mwb/remove-…
Aug 30, 2024
5728e1f
Updated changelog after release
Aug 30, 2024
3c6229a
Fixed misspelling and updated comment a bit
Aug 30, 2024
dd1d4bc
Merge branch 'mwb/remove-308-support' of github.com:realm/realm-core …
Aug 30, 2024
0d46d77
Merge branch 'master' of github.com:realm/realm-core into mwb/add-cor…
Aug 30, 2024
ebcfe93
Updates from review - removed some changes needed by redirect server …
Sep 4, 2024
9a9371d
rerun validation
Sep 4, 2024
307fdb7
Fixed TSAN error
Sep 5, 2024
2b2c59c
Merge branch 'master' of github.com:realm/realm-core into mwb/add-cor…
Sep 5, 2024
1d1edf9
Update location after auth failure; updated test comments
Sep 7, 2024
ce1aeec
I thought I removed this line...
Sep 7, 2024
a4e967a
Reverted line now that login is not always requesting location
Sep 7, 2024
761f18b
Updated changelog
Sep 7, 2024
49961ab
a little more cleanup
Sep 7, 2024
ee81ab4
Fixed refresh access token test
Sep 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reverted line now that login is not always requesting location
Michael Wilkerson-Barker committed Sep 7, 2024

Unverified

No user is associated with the committer email.
commit a4e967a27678191eebaee51819bdeab667982ebe
8 changes: 1 addition & 7 deletions test/object-store/sync/app.cpp
Original file line number Diff line number Diff line change
@@ -3787,13 +3787,7 @@ TEST_CASE("app: base_url", "[sync][app][base_url]") {
{
if (request.url.find("/location") != std::string::npos) {
CHECK(request.method == HttpMethod::get);
// Location is now requested again when the user logs in - only check the exepected
// url on the first location request - after that, it will be using the location_url
// value when requesting the location.
if (!location_requested)
CHECK_THAT(request.url, ContainsSubstring(expected_url));
else
CHECK_THAT(request.url, ContainsSubstring(location_url));
CHECK_THAT(request.url, ContainsSubstring(expected_url));
location_requested = true;
if (location_returns_error) {
completion(app::Response{static_cast<int>(sync::HTTPStatus::NotFound), 0, {}, "404 not found"});