feat(dask): introduce labels and node selector to Dask resources (#628) #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #628 +/- ##
==========================================
- Coverage 73.71% 73.65% -0.07%
==========================================
Files 17 17
Lines 1948 1951 +3
==========================================
+ Hits 1436 1437 +1
- Misses 512 514 +2
|
…nahub#628) This commit introduces support for adding labels and a node selector to Dask resources, allowing finer control over resource scheduling in K8s. Following changes are introduced: - `reana-run-dask-owner-uuid` and `reana-run-dask-workflow-uuid` label for Dask scheduler and worker pods in addition to cluster and autoscaler custom K8s resources. - runtime_jobs node selector for Dask scheduler and worker pods if `node_label_runtimejobs` is defined in `values.yaml`. Closes reanahub#623
tiborsimko
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces support for adding labels and a node selector to Dask resources, allowing finer control over resource scheduling in K8s. Following changes are introduced:
reana-run-dask-owner-uuidandreana-run-dask-workflow-uuidlabel for Dask scheduler and worker pods in addition to cluster and autoscaler custom K8s resources.runtime_jobs node selector for Dask scheduler and worker pods if
node_label_runtimejobsis defined invalues.yaml.Closes #623