feat: add workflow-uuid label to batch, dask, and session pods#668
Open
iamakamen wants to merge 2 commits into
Open
feat: add workflow-uuid label to batch, dask, and session pods#668iamakamen wants to merge 2 commits into
iamakamen wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a standardized workflow-uuid label to all REANA runtime workloads (Batch jobs, Dask clusters, and Interactive Sessions) to enable consistent identification and querying of resources across the platform.
- Adds
workflow-uuidlabel to batch workflow Job pods - Adds
workflow-uuidlabel to interactive session Deployment pods - Adds
workflow-uuidlabel to Dask cluster, autoscaler, and dashboard ingress resources
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| reana_workflow_controller/workflow_run_manager.py | Adds workflow-uuid label to batch Job metadata, paralleling the existing reana-run-batch-workflow-uuid label |
| reana_workflow_controller/k8s.py | Adds workflow-uuid label to interactive session Deployment pod template, alongside existing reana-run-session-workflow-uuid label |
| reana_workflow_controller/dask.py | Adds workflow-uuid label to Dask cluster metadata, autoscaler metadata, dashboard ingress middleware, and dashboard ingress resources, complementing existing reana-run-dask-workflow-uuid labels |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Hi @tiborsimko @jirikuncar @mr-c @dinosk, I wanted to follow up on this PR. Happy to refine or adjust based on feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR harmonises the metadata labeling by adding the
workflow-uuidlabel to all runtime workloads produced by the Workflow Controller.Closes #667
This change is part of a cross-repository update. Please merge in conjunction with: