-
Notifications
You must be signed in to change notification settings - Fork 46
Sponsors page design update #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@meetoza30 is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR redesigns the sponsors page to match the design consistency of other pages in the project. It transforms the sponsors page from a tab-based layout to a modern, responsive design with enhanced visual elements and improved user experience.
- Complete redesign of the sponsors page with a modern, gradient-based UI matching other project pages
- Replaced tab-based navigation with toggle buttons for better mobile experience
- Enhanced sponsor cards with improved styling, better avatar handling, and social media integration
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
File | Description |
---|---|
src/pages/our-sponsors/index.tsx | Complete rewrite of the main sponsors page component with new filtering logic, enhanced UI components, and improved data processing |
src/pages/our-sponsors/Sponsors.css | Comprehensive CSS redesign with modern styling, animations, responsive design, and theme-consistent colors |
src/pages/our-sponsors/SponsorCard/index.tsx | Enhanced sponsor card component with better error handling, avatar fallbacks, and improved social links display |
src/pages/our-sponsors/SponsorCard/SponsorCard.css | New CSS file for sponsor card styling with modern design elements, animations, and responsive features |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
// // Enhanced function to determine tier based on description and profile strength | ||
// const determineTier = (sponsor: any): 'platinum' | 'gold' | 'silver' | 'bronze' => { | ||
// const description = sponsor.description.toLowerCase(); | ||
// const socialCount = [sponsor.github, sponsor.linkedin, sponsor.twitter, sponsor.instagram].filter(Boolean).length; | ||
|
||
// // Platinum tier - Directors, Team leads, Major organizations | ||
// if (description.includes('director') || | ||
// description.includes('team lead') || | ||
// description.includes('founder') || | ||
// sponsor.name === 'Homebrew' || | ||
// sponsor.name === 'GSSOC' || | ||
// sponsor.name === 'Sarah Drasner' || | ||
// sponsor.name === 'Eduardo San Martin' || | ||
// sponsor.name === 'Razvan Stoenescu') { | ||
// return 'platinum'; | ||
// } | ||
|
||
// // Gold tier - Senior developers, Engineers, Multi-social presence | ||
// if (description.includes('engineer') || | ||
// description.includes('developer at') || | ||
// description.includes('sde at') || | ||
// description.includes('devops') || | ||
// description.includes('co-founder') || | ||
// socialCount >= 3) { | ||
// return 'gold'; | ||
// } | ||
|
||
// // Silver tier - Developers, Interns, Students at prestigious institutions | ||
// if (description.includes('developer') || | ||
// description.includes('intern') || | ||
// description.includes('iit') || | ||
// description.includes('iiit') || | ||
// socialCount >= 2) { | ||
// return 'silver'; | ||
// } | ||
|
||
// // Bronze tier - Default | ||
// return 'bronze'; | ||
// }; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large block of commented-out code should be removed. If this functionality might be needed in the future, consider using version control history or creating a separate feature branch instead of leaving commented code in the main codebase.
Copilot uses AI. Check for mistakes.
width: 100%; | ||
padding: 16px 16px 16px 48px; | ||
background: rgba(255, 255, 255, 0.1); | ||
background-color: purple; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hardcoded purple background color conflicts with the design system and appears to be debugging code that was accidentally left in. It should be removed or replaced with the appropriate design token.
background-color: purple; |
Copilot uses AI. Check for mistakes.
background-color: #e4405f; | ||
.search-input:focus { | ||
outline: none; | ||
color: black; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoded black color breaks the dark theme design. This should use the appropriate CSS custom property or design token that respects the theme system.
color: black; | |
color: var(--text-color); |
Copilot uses AI. Check for mistakes.
}) => { | ||
// ✅ FIXED: Handle undefined/empty names safely |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment references 'FIXED' which suggests this was debugging/development commentary that should be cleaned up. The comment should be more descriptive of what the function does rather than referencing the fix status.
// ✅ FIXED: Handle undefined/empty names safely | |
// Returns the initials of the sponsor's name, handling undefined or empty names safely. |
Copilot uses AI. Check for mistakes.
.toUpperCase() || 'UN'; // Fallback if no valid characters | ||
}; | ||
|
||
// ✅ FIXED: Validate social links more safely |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as above - 'FIXED' reference should be removed and replaced with a more descriptive comment about the function's purpose.
// ✅ FIXED: Validate social links more safely | |
// Build an array of valid social media links for the sponsor, filtering out empty or placeholder URLs |
Copilot uses AI. Check for mistakes.
{ url: instagram, icon: FaInstagram, label: 'Instagram', color: '#E4405F' }, | ||
].filter(link => link.url && link.url !== '#' && link.url.trim() !== ''); | ||
|
||
// ✅ FIXED: Ensure name and description are always strings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue - development commentary with 'FIXED' should be cleaned up and replaced with proper documentation about the safety checks being performed.
// ✅ FIXED: Ensure name and description are always strings | |
// Provide default values for name and description to ensure they are always strings. | |
// This prevents rendering issues if these props are missing or undefined. |
Copilot uses AI. Check for mistakes.
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@meetoza30 loved your dev. |
Description
Updated the design of the page so that it matches with the design of the others pages..
Fixes #457
Type of Change
Changes Made
@sanjay-kv when will i get sponsorship? 😅
Dependencies
Checklist
npm run build
and attached scrrenshot in this PR.