Skip to content

Conversation

NishchayRajput
Copy link

@NishchayRajput NishchayRajput commented Oct 4, 2025

Description

Fixes #776

Type of Change

  • New feature (e.g., new page, component, or functionality)
  • Bug fix (non-breaking change that fixes an issue)
  • UI/UX improvement (design, layout, or styling updates)
  • Performance optimization (e.g., code splitting, caching)
  • Documentation update (README, contribution guidelines, etc.)
  • Other (please specify):

Changes Made

Dependencies

  • List any new dependencies or tools required for this change.
  • Mention any version updates or configurations that need to be considered.

Checklist

  • My code follows the style guidelines of this project.
  • I have tested my changes across major browsers and devices
  • My changes do not generate new console warnings or errors .
  • I ran npm run build and attached screenshot(s) in this PR.
  • This is already assigned Issue to me, not an unassigned issue.

@vercel
Copy link
Contributor

vercel bot commented Oct 4, 2025

@NishchayRajput is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

github-actions bot commented Oct 4, 2025

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@github-actions github-actions bot added hacktoberfest-accepted level 1 10 points recode this is label for leaderboard labels Oct 4, 2025
@iitzIrFan
Copy link
Member

@NishchayRajput I was unable to find the issue in the issues section, can you link this pr to that, issue. Thanks for your changes :)

@github-actions
Copy link

github-actions bot commented Oct 4, 2025

Synced data from Linked Issues

Labels:

  • level 1
  • recode
  • hacktoberfest-accepted

Assignees:

  • NishchayRajput

Milestones:

  • recode:launch 3.0

@NishchayRajput
Copy link
Author

Done! I missed it. Sorry:)

@iitzIrFan
Copy link
Member

No issue, will review the pr soon ! @NishchayRajput

@iitzIrFan iitzIrFan moved this to In Progress in @recode-web Oct 4, 2025
Copy link
Member

@iitzIrFan iitzIrFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding Quote theme to the FAQ's but, there is a glitch in the component as seen in the video sample below, can you please optimize that, rest all is fine.

2025-10-04.19-22-46.mp4

@iitzIrFan iitzIrFan added the under review Review under the maintainers or the admins label Oct 4, 2025
@NishchayRajput
Copy link
Author

I hope it fixes it now!

@iitzIrFan iitzIrFan self-requested a review October 4, 2025 14:23
Copy link
Member

@iitzIrFan iitzIrFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart fix there, LGTM ! @NishchayRajput
@sanjay-kv Ready for merge.

@iitzIrFan iitzIrFan added the Ready for Merge PR has passed reviews and checks, and is ready to be merged into the main branch. label Oct 6, 2025
@Adez017
Copy link
Member

Adez017 commented Oct 8, 2025

@sanjay-kv Ready to be merged .

@vercel
Copy link
Contributor

vercel bot commented Oct 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
recode-website Error Error Oct 10, 2025 1:27am

@sanjay-kv
Copy link
Member

12:25:04.319 Running build in Washington, D.C., USA (East) – iad1
12:25:04.320 Build machine configuration: 4 cores, 8 GB
12:25:04.338 Cloning github.com/recodehive/recode-website (Branch: fix-faq-block, Commit: eb6a0f0)
12:25:06.592 Cloning completed: 2.254s
12:25:07.698 Restored build cache from previous deployment (FN5FeSQ74cWNe8mnzpSaa56hAogU)
12:25:08.830 Running "vercel build"
12:25:09.241 Vercel CLI 48.2.9
12:25:09.852 Warning: Detected "engines": { "node": ">=18.0" } in your package.json that will automatically upgrade when a new major Node.js Version is released. Learn More: http://vercel.link/node-version
12:25:09.857 Installing dependencies...
12:25:13.175
12:25:13.175 > [email protected] prepare
12:25:13.175 > husky
12:25:13.175
12:25:13.249
12:25:13.249 up to date in 3s
12:25:13.249
12:25:13.249 560 packages are looking for funding
12:25:13.250 run npm fund for details
12:25:13.295 Running "npm run build"
12:25:13.412
12:25:13.413 > [email protected] build
12:25:13.413 > docusaurus build
12:25:13.413
12:25:14.768 [INFO] [en] Creating an optimized production build...
12:25:16.004 [info] [webpackbar] Compiling Client
12:25:16.024 [info] [webpackbar] Compiling Server
12:26:19.501 [success] [webpackbar] Server: Compiled with some errors in 1.06m
12:27:02.322 [success] [webpackbar] Client: Compiled with some errors in 1.77m
12:27:02.331 [ERROR] Client bundle compiled with errors therefore further build is impossible.
12:27:02.331 SyntaxError: /vercel/path0/src/components/faqs/faqs.tsx: Expected corresponding JSX closing tag for

. (162:20)
12:27:02.331 �[0m �[90m 160 |�[39m }}
12:27:02.331 �[90m 161 |�[39m �[33m/�[39m�[33m>�[39m
12:27:02.332 �[31m�[1m>�[22m�[39m�[90m 162 |�[39m �[33m<�[39m�[33m/�[39m�[33mmotion�[39m�[33m.�[39mdiv�[33m>�[39m
12:27:02.332 �[90m |�[39m �[31m�[1m^�[22m�[39m
12:27:02.332 �[90m 163 |�[39m �[33m<�[39m�[33m/�[39m�[33mmotion�[39m�[33m.�[39mdiv�[33m>�[39m
12:27:02.332 �[90m 164 |�[39m ))}
12:27:02.332 �[90m 165 |�[39m �[33m<�[39m�[33m/�[39m�[33mdiv�[39m�[33m>�[39m�[0m
12:27:02.432 Error: Command "npm run build" exited with 1

deployment failed @NishchayRajput

@NishchayRajput
Copy link
Author

Sure will look into it

@iitzIrFan iitzIrFan self-requested a review October 10, 2025 18:27
Copy link
Member

@iitzIrFan iitzIrFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try running npm run build and if, issues then, do let me know :)

@sanjay-kv sanjay-kv added this to the recode:launch 3.0 milestone Oct 12, 2025
@Adez017
Copy link
Member

Adez017 commented Oct 13, 2025

@NishchayRajput , are you working on it .

@NishchayRajput
Copy link
Author

@NishchayRajput , are you working on it .

Yaa will do it by today! Sorry for delay was stuck somewhere!

@iitzIrFan iitzIrFan removed the Ready for Merge PR has passed reviews and checks, and is ready to be merged into the main branch. label Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted level 1 10 points recode this is label for leaderboard under review Review under the maintainers or the admins

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

🐞[Bug]: FAQ answer indent and visibility

4 participants