Skip to content
This repository has been archived by the owner on Jul 2, 2022. It is now read-only.

Supported offline #115

Merged
merged 3 commits into from
May 7, 2019
Merged

Supported offline #115

merged 3 commits into from
May 7, 2019

Conversation

ipragmatechadmin
Copy link

Description

Added the support for offline so that app works even the internet is not available. Also fixes little issues.

@Qolzam
Copy link
Member

Qolzam commented May 5, 2019

I appreciate your pull request @kapilip . Everything work well. I haven't focused on security issues for this project much, however there is a point that redux offline save redux store data in local storage which cause security issues. Do you have any idea about that?

@ipragmatechadmin
Copy link
Author

@Qolzam Yes, I have read the security issues with local storage and we shouldn't be storing the sensitive information like the user's credentials or payment details in it. So IMHO we aren't storing any of these in the local storage and storing the public information which shall be available to other users. Let me know your thoughts.
BTW you are doing a wonderful job, we have used this structure for our internal app and later added offline support for our app. We would happy to contribute to react-social-network as we add more things in our app :)

@Qolzam
Copy link
Member

Qolzam commented May 5, 2019

@kapilip I am happy to hear that It's helpful to your project. And I do appreciate your contribution. You are right, not sure about next:branch and if personal data which comes to redux store is important for user or not, however we need be aware of that. How is your idea that we make a pluggable feature of offline-support? Kind of option for developer!

By the way I am currently working on v0.7.0:branch NOT READY (I will release backend as soon as possible) in my spare time and it's going so slow, but I am trying to make this social more independent to Firebase (#109).
Indeed I am trying to make this project closer to production. But as you know there are 531,664 lines of code (in src folder) need to be maintained and developed.
Maybe you are more interested in social network with K8S for real world production which will come after (#109).

Thanks again!

@ipragmatechadmin
Copy link
Author

@kapilip I am happy to hear that It's helpful to your project. And I do appreciate your contribution. You are right, not sure about next:branch and if personal data which comes to redux store is important for user or not, however we need be aware of that. How is your idea that we make a pluggable feature of offline-support? Kind of option for developer!

By the way I am currently working on v0.7.0:branch NOT READY (I will release backend as soon as possible) in my spare time and it's going so slow, but I am trying to make this social more independent to Firebase (#109).
Indeed I am trying to make this project closer to production. But as you know there are 531,664 lines of code (in src folder) need to be maintained and developed.
Maybe you are more interested in social network with K8S for real-world production which will come after (#109).

Thanks again!

That's a good idea to make offline support as optional. Could you suggest how can I make it a plugin?

Ok, I shall try to contribute to v0.7.0 branch. Could you tell which features you would like me to work on? I would be happy to contribute it to the project.

@ipragmatechadmin
Copy link
Author

@Qolzam I tried to run v.0.7.0 and looks like I would also need to the source code for the API. Could you also push the code in the git repository so that I can run v0.7.0 locally?

@Qolzam
Copy link
Member

Qolzam commented May 7, 2019

@kapilip Thanks for checking, you are great 👍 . Can you tell why you can not start? This branch is not ready yet, It's a little bit buggy :). After completing OAuth I will push complete backed. Until next week I will organize backend too.

About plugin let's discuss here #97

@Qolzam Qolzam merged commit bdc184d into red-gold:next May 7, 2019
@ipragmatechadmin
Copy link
Author

@Qolzam We shall be waiting for the branch to be ready :-)

@Qolzam
Copy link
Member

Qolzam commented May 12, 2019

Hello @kapilip. Here is the back-end. Please let me know if you face with any bugs.

Thanks!

@ipragmatechadmin
Copy link
Author

@Qolzam Thanks a lot :-) We shall take a look and let you know if we have any question

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants