-
Notifications
You must be signed in to change notification settings - Fork 484
Conversation
I appreciate your pull request @kapilip . Everything work well. I haven't focused on security issues for this project much, however there is a point that redux offline save redux store data in local storage which cause security issues. Do you have any idea about that? |
@Qolzam Yes, I have read the security issues with local storage and we shouldn't be storing the sensitive information like the user's credentials or payment details in it. So IMHO we aren't storing any of these in the local storage and storing the public information which shall be available to other users. Let me know your thoughts. |
@kapilip I am happy to hear that It's helpful to your project. And I do appreciate your contribution. You are right, not sure about next:branch and if personal data which comes to redux store is important for user or not, however we need be aware of that. How is your idea that we make a pluggable feature of offline-support? Kind of option for developer! By the way I am currently working on v0.7.0:branch NOT READY (I will release backend as soon as possible) in my spare time and it's going so slow, but I am trying to make this social more independent to Firebase (#109). Thanks again! |
That's a good idea to make offline support as optional. Could you suggest how can I make it a plugin? Ok, I shall try to contribute to v0.7.0 branch. Could you tell which features you would like me to work on? I would be happy to contribute it to the project. |
@Qolzam I tried to run v.0.7.0 and looks like I would also need to the source code for the API. Could you also push the code in the git repository so that I can run v0.7.0 locally? |
@Qolzam We shall be waiting for the branch to be ready :-) |
@Qolzam Thanks a lot :-) We shall take a look and let you know if we have any question |
Description
Added the support for offline so that app works even the internet is not available. Also fixes little issues.