-
Notifications
You must be signed in to change notification settings - Fork 321
kueue: Assign release priority to internal-pipelinerun child pipelines (dev/staging/ocp) #10302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Gemini AI Assistant AvailableHi @arewm! I'm here to help with your pull request. You can interact with me using the following commands: Available Commands
How to Use
PermissionsOnly OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage. This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance. |
|
🤖 Hi @arewm, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
🤖 Pipeline Failure AnalysisCategory: Test The end-to-end tests failed due to a timeout in the 📋 Technical DetailsImmediate CauseThe Contributing FactorsThe context reveals that a ImpactThe failure to create or detect the expected 🔍 Evidenceappstudio-e2e-tests/redhat-appstudio-e2eCategory: Logs:
|
4f309b8 to
7d9da59
Compare
filariow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
Feel free to unhold when you're ready to merge
It would be nice if we could split it in two: one for dev+staging and one for production.
|
Doesn't signing pipeline run in the internal common clusters? |
gbenhaim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test for this change in
| Tekton-Kueue Configuration Test |
7d9da59 to
c43681d
Compare
It does for external clusters. Internal clusters run the internal service pipelines directly on the same cluster. This is only a fix needed for the internal clusters, but having an extra kueue configured shouldn't affect external clusters. |
Child pipelines created by internal-pipelinerun (such as signing pipelines) were receiving the default priority (400) instead of release priority (1000). This caused them to be blocked behind multi-arch build pipelines waiting for ppc64le/s390x capacity, even though signing pipelines don't require those resources. Add a CEL rule to recognize pipelines with the internal-services.appstudio.openshift.io/pipelinerun-uid label and assign them konflux-release priority, matching their parent managed release pipelines. Assisted-by: Claude Code (Opus 4.5)
c43681d to
cd3cb37
Compare
|
@gbenhaim, I am not familiar with the tests, but Claude added one. If that is not correct, I can go back and modify this. I also moved the OCP cluster to this dev/stage PR as that is the most affected cluster due to the continuous build pipelines running. |
Yes, the signing pipelines run on the internal clusters (kflux-ocp-p01). I've updated this PR to include kflux-ocp-p01 config alongside dev/staging, and separated the production base config into a separate PR (#10310) for the external clusters where this rule won't apply (but is harmless). Added test coverage for the new CEL rule as well. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arewm, filariow, gbenhaim The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Summary
internal-services.appstudio.openshift.io/pipelinerun-uidlabelkonflux-releasepriority, matching their parent managed release pipelinesBackground
Child pipelines created by internal-pipelinerun (such as signing pipelines) were receiving the default priority (400) instead of release priority (1000). This caused them to be blocked behind multi-arch build pipelines waiting for ppc64le/s390x capacity, even though signing pipelines don't require those resources.
🤖 Generated with Claude Code