-
Notifications
You must be signed in to change notification settings - Fork 313
feat(PVO11Y-4928): Implement Otel sidecar for Konflux UI #8365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PVO11Y-4928): Implement Otel sidecar for Konflux UI #8365
Conversation
Skipping CI for Draft Pull Request. |
🤖 Gemini AI Assistant AvailableHi @martysp21! I'm here to help with your pull request. You can interact with me using the following commands: Available Commands
How to Use
PermissionsOnly OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage. This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance. |
🤖 Hi @martysp21, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
The tests run in the Draft of this PR do not seem to be related with the changes made by this PR. |
Reviewing possibility of changing the otel collector image to internal one. |
As stated in the tests, the container is still missing
|
name: otel-collector | ||
command: | ||
- "/otelcol-contrib" | ||
- "--config=/conf/otel-collector-conf.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means, the command will be -> /usr/local/bin/otel-collector-sp --config /etc/otelcol-contrib/config.yaml.
Can we please test this @martysp21 locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed and tested. Please double check that it is mounted correctly, because that part is different from local testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: martysp21, mftb, raks-tt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4c7cae2
into
redhat-appstudio:main
KONFLUX-5285
This is an implementation of OTEL sidecar for Konflux UI Nginx proxy in order to collect all necessary HTTP traffic data and convert them into metrics. These metrics will be then used to create alert for inaccessibility.
The otel image will change before this PR is merged to the otel-collector-sp after it is updated
Changes:
nginx.conf
otel-collector-conf.yaml
proxy.yaml
The changes can be also found at: https://docs.google.com/document/d/1RTvHJl90rvbVMxM6a8ag9dWTGTcTIow_zapaxCYEmzE/edit?tab=t.0