Skip to content

Conversation

martysp21
Copy link
Contributor

@martysp21 martysp21 commented Sep 29, 2025

KONFLUX-5285
This is an implementation of OTEL sidecar for Konflux UI Nginx proxy in order to collect all necessary HTTP traffic data and convert them into metrics. These metrics will be then used to create alert for inaccessibility.

The otel image will change before this PR is merged to the otel-collector-sp after it is updated

Changes:
nginx.conf

  • added a new logformat that will be saved into access.log
  • The new logformat is the same as the default ngingx format "combined", I redefined it for better readability and easier future maintenance
  • access.log is located at /var/log/nginx/access.log and stores all the logs of in the combined_cusotm format

otel-collector-conf.yaml

  • configuration for the otel collector
  • takes logs from the access.log and parses them using regex
  • the data are then transformed into metrics
  • this is the main file to change how the output lookslike and will probably need most of the refinement

proxy.yaml

The changes can be also found at: https://docs.google.com/document/d/1RTvHJl90rvbVMxM6a8ag9dWTGTcTIow_zapaxCYEmzE/edit?tab=t.0

Copy link

openshift-ci bot commented Sep 29, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

🤖 Gemini AI Assistant Available

Hi @martysp21! I'm here to help with your pull request. You can interact with me using the following commands:

Available Commands

  • @gemini-cli /review - Request a comprehensive code review

    • Example: @gemini-cli /review Please focus on security and performance
  • @gemini-cli <your question> - Ask me anything about the codebase

    • Example: @gemini-cli How can I improve this function?
    • Example: @gemini-cli What are the best practices for error handling here?

How to Use

  1. Simply type one of the commands above in a comment on this PR
  2. I'll analyze your code and provide detailed feedback
  3. You can track my progress in the workflow logs

Permissions

Only OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage.


This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance.

Copy link
Contributor

🤖 Hi @martysp21, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@martysp21 martysp21 changed the title feat(KONFLUX-5285): Implement Otel sidecar for Konflux UI feat(PVO11Y-4928): Implement Otel sidecar for Konflux UI Sep 29, 2025
@martysp21
Copy link
Contributor Author

The tests run in the Draft of this PR do not seem to be related with the changes made by this PR.
Asking for advice from Konflux Ui when the PR will be opened.

@martysp21
Copy link
Contributor Author

Reviewing possibility of changing the otel collector image to internal one.

@martysp21 martysp21 marked this pull request as ready for review October 2, 2025 07:58
@openshift-ci openshift-ci bot requested review from gbenhaim and rrosatti October 2, 2025 07:58
@TominoFTW
Copy link
Contributor

TominoFTW commented Oct 3, 2025

As stated in the tests, the container is still missing runAsUser label.

Error when running kustomize build for components/konflux-ui/staging/stone-stage-p01: Error: remove operation does not apply: doc is missing path: "/spec/template/spec/containers/1/securityContext/runAsUser": missing value
Error when running kustomize build for components/konflux-ui/staging/stone-stg-rh01: Error: remove operation does not apply: doc is missing path: "/spec/template/spec/containers/1/securityContext/runAsUser": missing value

name: otel-collector
command:
- "/otelcol-contrib"
- "--config=/conf/otel-collector-conf.yaml"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means, the command will be -> /usr/local/bin/otel-collector-sp --config /etc/otelcol-contrib/config.yaml.

Can we please test this @martysp21 locally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed and tested. Please double check that it is mounted correctly, because that part is different from local testing.

Copy link
Contributor

@raks-tt raks-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mftb
Copy link
Contributor

mftb commented Oct 8, 2025

/retest

Copy link
Contributor

@mftb mftb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Oct 8, 2025
Copy link

openshift-ci bot commented Oct 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: martysp21, mftb, raks-tt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 8, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 4c7cae2 into redhat-appstudio:main Oct 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants