Add yamllint checks

.github/workflows/chainsaw-tests.yaml

@@ -37,7 +37,7 @@ jobs:
       uses: helm/kind-action@v1
 
     - uses: actions/checkout@v4
-    
+
     - name: Install Dependencies
       shell: bash
       run: |

.github/workflows/gemini-dispatch.yml

@@ -109,7 +109,7 @@ jobs:
             } else {
               core.setOutput('command', 'fallthrough');
             }
-      
+
       - name: 'Add Gemini helper comment'
         if: '${{ github.event_name }}.${{ github.event.action }} == "pull_request.opened"'
         env:
@@ -125,7 +125,7 @@ jobs:
 
             - **`@gemini-cli /review`** - Request a comprehensive code review
               - Example: `@gemini-cli /review Please focus on security and performance`
-            
+
             - **`@gemini-cli <your question>`** - Ask me anything about the codebase
               - Example: `@gemini-cli How can I improve this function?`
               - Example: `@gemini-cli What are the best practices for error handling here?`
@@ -141,7 +141,7 @@ jobs:
             Only **OWNER**, **MEMBER**, or **COLLABORATOR** users can trigger my responses. This ensures secure and appropriate usage.
 
             ---
-            
+
             *This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance.*
         run: |-
           gh pr comment "${PR_NUMBER}" \

.github/workflows/gemini-review.yml

@@ -150,7 +150,7 @@ jobs:
 
             2. **Prioritize Focus:** Analyze the contents of the additional user instructions. Use this context to prioritize specific areas in your review (e.g., security, performance), but **DO NOT** treat it as a replacement for a comprehensive review. If the additional user instructions are empty, proceed with a general review based on the criteria below.
 
-            3. **Review Code:** Meticulously review the code provided returned from `mcp__github__get_pull_request_diff` according to the **Review Criteria**. 
+            3. **Review Code:** Meticulously review the code provided returned from `mcp__github__get_pull_request_diff` according to the **Review Criteria**.
 
             ### Step 2: Formulate Review Comments
 

.github/workflows/test-tekton-kueue-config.yaml

@@ -42,4 +42,4 @@ jobs:
       - name: Report success
         if: success()
         run: |
-          echo "✅ All Tekton-Kueue CEL expression tests passed successfully" 
+          echo "✅ All Tekton-Kueue CEL expression tests passed successfully"

.github/workflows/verify-kueue-queue-configs.yaml

@@ -34,4 +34,4 @@ jobs:
       - name: Report success
         if: success()
         run: |
-          echo "✅ All Kueue queue configurations are up to date with their corresponding host-config files" 
+          echo "✅ All Kueue queue configurations are up to date with their corresponding host-config files"

.github/workflows/yamllint.yaml

@@ -0,0 +1,16 @@
+name: Lint manifests with yamllint
+
+on:
+  pull_request:
+    branches: [ main ]
+  push:
+    branches: [ main ]
+
+jobs:
+  yamllint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Lint yaml manifests
+        run: |
+          yamllint -f github .

.yamllint.yaml

@@ -0,0 +1,10 @@
+extends: relaxed
+
+ignore:
+  # we don't control the content of helm charts, so don't enforce our standards on them
+  - '**/charts/'
+  - '**/templates/'
+
+rules:
+  indentation: disable
+  line-length: disable

argo-cd-apps/app-of-app-sets/base/all-application-sets.yaml

@@ -12,7 +12,7 @@ spec:
     namespace: argocd-staging
     server: https://kubernetes.default.svc
   syncPolicy:
-    automated: 
+    automated:
       prune: true
       selfHeal: true
     syncOptions:

argo-cd-apps/base/all-clusters/infra-deployments/authentication/authentication.yaml

@@ -36,7 +36,7 @@ spec:
         namespace: default # not relevant yet since every object has an explicit namespace.
         server: '{{server}}'
       syncPolicy:
-        automated: 
+        automated:
           prune: true
           selfHeal: true
         syncOptions:

argo-cd-apps/base/all-clusters/infra-deployments/cluster-secret-store/cluster-secret-store.yaml

@@ -28,7 +28,7 @@ spec:
         namespace: default
         server: '{{server}}'
       syncPolicy:
-        automated: 
+        automated:
           prune: true
           selfHeal: true
         syncOptions:

argo-cd-apps/base/all-clusters/infra-deployments/disable-self-provisioning-for-all-cluster/disable-self-provisioning.yaml

@@ -10,7 +10,7 @@ spec:
         generators:
           - clusters:
               values:
-                sourceRoot: configs/disable-self-provisioning-for-all-cluster                
+                sourceRoot: configs/disable-self-provisioning-for-all-cluster
                 clusterDir: ""
           - list:
               elements: []
@@ -20,7 +20,7 @@ spec:
     spec:
       project: default
       source:
-        path: configs/disable-self-provisioning-for-all-cluster/ 
+        path: configs/disable-self-provisioning-for-all-cluster/
         repoURL: https://github.com/redhat-appstudio/infra-deployments.git
         targetRevision: main
       destination:

argo-cd-apps/base/all-clusters/infra-deployments/monitoring-workload-grafana/monitoring-workload-grafana.yaml

@@ -28,7 +28,7 @@ spec:
         namespace: appstudio-grafana
         server: '{{server}}'
       syncPolicy:
-        automated: 
+        automated:
           prune: true
           selfHeal: true
         syncOptions:

argo-cd-apps/base/backup/backup.yaml

@@ -30,7 +30,7 @@ spec:
         namespace: default
         server: '{{server}}'
       syncPolicy:
-        automated: 
+        automated:
           prune: true
           selfHeal: true
         syncOptions:

argo-cd-apps/base/ci-helper-app/ci-helper-app.yaml

@@ -41,4 +41,4 @@ spec:
           backoff:
             duration: 10s
             factor: 2
-            maxDuration: 3m
+            maxDuration: 3m

argo-cd-apps/base/ci-helper-app/kustomization.yaml

@@ -3,4 +3,4 @@ kind: Kustomization
 resources:
 - ci-helper-app.yaml
 components:
-  - ../../k-components/inject-infra-deployments-repo-details
+  - ../../k-components/inject-infra-deployments-repo-details

argo-cd-apps/base/host/ingresscontroller/kustomization.yaml

@@ -3,4 +3,4 @@ kind: Kustomization
 resources:
   - ingresscontroller.yaml
 components:
-  - ../../../k-components/inject-infra-deployments-repo-details
+  - ../../../k-components/inject-infra-deployments-repo-details

argo-cd-apps/base/host/sprayproxy/sprayproxy.yaml

@@ -1,4 +1,3 @@
-
 apiVersion: argoproj.io/v1alpha1
 kind: ApplicationSet
 metadata:

argo-cd-apps/base/member/infra-deployments/application-api/application-api.yaml

@@ -18,7 +18,7 @@ spec:
         namespace: application-api
         server: '{{server}}'
       syncPolicy:
-        automated: 
+        automated:
           prune: true
           selfHeal: true
         syncOptions:

argo-cd-apps/base/member/infra-deployments/build-templates/build-templates.yaml

@@ -34,7 +34,7 @@ spec:
           jqPathExpressions:
           - .imagePullSecrets[] | select(.name | startswith("appstudio-pipeline-dockercfg"))
       syncPolicy:
-        automated: 
+        automated:
           prune: true
           selfHeal: true
         syncOptions:

argo-cd-apps/base/member/infra-deployments/has/has.yaml

@@ -28,7 +28,7 @@ spec:
         namespace: application-service
         server: '{{server}}'
       syncPolicy:
-        automated: 
+        automated:
           prune: true
           selfHeal: true
         syncOptions:

argo-cd-apps/base/member/infra-deployments/internal-services/internal-services.yaml

@@ -18,7 +18,7 @@ spec:
         namespace: internal-services
         server: '{{server}}'
       syncPolicy:
-        automated: 
+        automated:
           prune: true
           selfHeal: true
         syncOptions:

argo-cd-apps/base/member/infra-deployments/konflux-kite/konflux-kite.yaml

@@ -54,4 +54,3 @@ spec:
           limit: 50
           backoff:
             duration: 15s
-

argo-cd-apps/base/member/infra-deployments/perf-team-prometheus-reader/perf-team-prometheus-reader.yaml

@@ -28,7 +28,7 @@ spec:
         namespace: perf-team-prometheus-reader
         server: '{{server}}'
       syncPolicy:
-        automated: 
+        automated:
           prune: true
           selfHeal: true
         syncOptions:

argo-cd-apps/base/member/infra-deployments/project-controller/project-controller.yaml

@@ -28,7 +28,7 @@ spec:
         namespace: project-controller
         server: '{{server}}'
       syncPolicy:
-        automated: 
+        automated:
           prune: true
           selfHeal: true
         syncOptions:

argo-cd-apps/base/member/infra-deployments/release/release.yaml

@@ -28,7 +28,7 @@ spec:
         namespace: release-service
         server: '{{server}}'
       syncPolicy:
-        automated: 
+        automated:
           prune: true
           selfHeal: true
         syncOptions:

argo-cd-apps/base/quality-dashboard/kustomization.yaml

@@ -3,4 +3,4 @@ kind: Kustomization
 resources:
 - quality-dashboard.yaml
 components:
-  - ../../k-components/inject-infra-deployments-repo-details
+  - ../../k-components/inject-infra-deployments-repo-details

argo-cd-apps/base/quality-dashboard/quality-dashboard.yaml

@@ -41,4 +41,4 @@ spec:
           backoff:
             duration: 10s
             factor: 2
-            maxDuration: 3m
+            maxDuration: 3m

argo-cd-apps/k-components/deploy-to-host-cluster/kustomization.yaml

@@ -6,4 +6,4 @@ patches:
     target:
       group: argoproj.io
       version: v1alpha1
-      kind: ApplicationSet
+      kind: ApplicationSet

components/application-api/allow-argocd-to-manage.yaml

@@ -10,5 +10,4 @@ roleRef:
 subjects:
 - kind: ServiceAccount
   name: openshift-gitops-argocd-application-controller
-  namespace: openshift-gitops 
-
+  namespace: openshift-gitops

components/application-api/argocd-permissions.yaml

@@ -25,4 +25,4 @@ roleRef:
 subjects:
 - kind: ServiceAccount
   name: openshift-gitops-argocd-application-controller
-  namespace: application-api 
+  namespace: application-api

components/application-api/kustomization.yaml

@@ -5,4 +5,4 @@ resources:
 
 
 apiVersion: kustomize.config.k8s.io/v1beta1
-kind: Kustomization
+kind: Kustomization

components/build-service/components/webhook-config/webhook-config-patch.yaml

@@ -12,7 +12,7 @@
 
 - op: add
   path: /spec/template/spec/volumes/-
-  value: 
+  value:
     name: webhook-config
     configMap:
       name: webhook-config

components/build-service/production/stone-prod-p01/kustomization.yaml

@@ -13,7 +13,7 @@ patches:
 
 configMapGenerator:
   - name: webhook-config
-    files: 
+    files:
       - webhook-config.json
 
 components:

components/build-service/staging/stone-stage-p01/kustomization.yaml

@@ -13,7 +13,7 @@ patches:
 
 configMapGenerator:
   - name: webhook-config
-    files: 
+    files:
       - webhook-config.json
 
 components:

components/build-templates/base/0-namespace.yaml

@@ -2,8 +2,8 @@ apiVersion: v1
 kind: Namespace
 metadata:
   name: build-templates
-  labels:  
+  labels:
     argocd.argoproj.io/managed-by: openshift-gitops
 spec:
   finalizers:
-  - kubernetes
+  - kubernetes

components/build-templates/base/e2e/rolebinding.yaml

@@ -2,11 +2,11 @@
 apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
-  name:  edit-pipeline-from-build-templates
+  name: edit-pipeline-from-build-templates
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: ClusterRole
-  name:  edit
+  name: edit
 subjects:
 - kind: ServiceAccount
   name: appstudio-pipeline
@@ -21,11 +21,11 @@ subjects:
 apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
-  name:  edit-pipeline-from-build-templates-namespace
+  name: edit-pipeline-from-build-templates-namespace
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: Role
-  name:  edit-namespace
+  name: edit-namespace
 subjects:
 - kind: ServiceAccount
   name: appstudio-pipeline
@@ -40,11 +40,11 @@ subjects:
 apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
-  name:  admin-buildpipelineselectors-from-ci-namespaces
+  name: admin-buildpipelineselectors-from-ci-namespaces
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: Role
-  name:  admin-buildpipelineselectors
+  name: admin-buildpipelineselectors
 subjects:
 - kind: ServiceAccount
   name: appstudio-pipeline

components/ci-helper-app/base/kustomization.yaml

@@ -11,4 +11,4 @@ images:
   newName: quay.io/konflux-ci/ci-helper-app
   newTag: c74e02a133e09ed7cbb628919aaaa5cd3325375d
 
-namespace: ci-helper-app
+namespace: ci-helper-app

components/ci-helper-app/base/rbac/ci-helper-app.yaml

@@ -28,4 +28,4 @@ subjects:
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: Role
-  name: ci-helper-app-maintainer
+  name: ci-helper-app-maintainer

components/ci-helper-app/base/rbac/kustomization.yaml

@@ -1,4 +1,4 @@
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 resources:
-  - ci-helper-app.yaml
+  - ci-helper-app.yaml

components/ci-helper-app/development/kustomization.yaml

@@ -1,4 +1,4 @@
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 resources:
-- ../base
+- ../base

components/ci-helper-app/staging/external-secrets/ci-helper-app-secrets.yaml

@@ -16,4 +16,4 @@ spec:
   target:
     creationPolicy: Owner
     deletionPolicy: Delete
-    name: ci-helper-app-secrets
+    name: ci-helper-app-secrets