Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non-OpenShift K8s to managed-gitops, testing via k3d #838

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Jan 31, 2025

Description:

  • Add support for non-OpenShift K8s to managed-gitops, primarily by removing references to Routes and ArgoCD CR
  • Add initial testing via k3d

Link to JIRA Story (if applicable): N/A

Copy link
Contributor

openshift-ci bot commented Jan 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgwest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Copy link
Contributor

openshift-ci bot commented Jan 31, 2025

@jgwest: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/managed-gitops-e2e-tests 7b5aac9 link true /test managed-gitops-e2e-tests
ci/prow/images 7b5aac9 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.80%. Comparing base (017be24) to head (7b5aac9).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
cluster-agent/utils/argocd_login_credentials.go 57.14% 1 Missing and 2 partials ⚠️

❌ Your project check has failed because the head coverage (60.80%) is below the adjusted base coverage (62.60%). You can increase the head coverage or adjust the Removed Code Behavior.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
- Coverage   62.76%   60.80%   -1.97%     
==========================================
  Files          98       99       +1     
  Lines       18914    19053     +139     
==========================================
- Hits        11872    11585     -287     
- Misses       5722     6150     +428     
+ Partials     1320     1318       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant