Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure source-repo pipeline #166

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

tnevrlka
Copy link
Member

@tnevrlka tnevrlka commented Mar 19, 2025

Based on #137 which should be merged first.
Review the last commit that adds the Azure source-repo pipeline

@tnevrlka tnevrlka marked this pull request as draft March 19, 2025 15:06
# NEXUS_IO_CREDS_USR: ${{ secrets.NEXUS_IO_CREDS_USR }}
# NEXUS_IO_CREDS_PSW: ${{ secrets.NEXUS_IO_CREDS_PSW }}
# Used to verify the image signature and attestation
COSIGN_PUBLIC_KEY: ${{ vars.COSIGN_PUBLIC_KEY }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra white-space here.

bash /work/rhtap/cosign-sign-attest.sh
name: Build
env:
ROX_API_TOKEN: $(ROX_API_TOKEN)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that passing in secrets has to be done this way: https://learn.microsoft.com/en-us/azure/devops/pipelines/process/variables?view=azure-devops&tabs=yaml%2Cbatch#secret-variables

Not all the steps here require all the secrets, but this is good enough for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aware of the issue (still better than when everything was a secret...), but I think this is something that should be handled when rethinking the current Nunjucks generation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree 100%.

@tnevrlka tnevrlka force-pushed the azure-source-repo branch from 22b0c14 to 3ed9470 Compare March 31, 2025 20:37
@tnevrlka tnevrlka requested a review from lcarva March 31, 2025 20:48
@tnevrlka tnevrlka marked this pull request as ready for review March 31, 2025 22:32
Add the template that is used for generating source-repo Azure
Pipelines pipelines definition.
Secrets have to be passed as environment variables in the workflow
files -> include the variables that are needed for Azure to work
Include the generated pipeline definitions

Signed-off-by: Tomáš Nevrlka <[email protected]>
@tnevrlka tnevrlka force-pushed the azure-source-repo branch from 3ed9470 to d583f3c Compare April 1, 2025 13:08
@tnevrlka tnevrlka merged commit 6fe3c26 into redhat-appstudio:main Apr 1, 2025
5 checks passed
@tnevrlka tnevrlka deleted the azure-source-repo branch April 1, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants