-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure source-repo pipeline #166
Conversation
# NEXUS_IO_CREDS_USR: ${{ secrets.NEXUS_IO_CREDS_USR }} | ||
# NEXUS_IO_CREDS_PSW: ${{ secrets.NEXUS_IO_CREDS_PSW }} | ||
# Used to verify the image signature and attestation | ||
COSIGN_PUBLIC_KEY: ${{ vars.COSIGN_PUBLIC_KEY }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra white-space here.
bash /work/rhtap/cosign-sign-attest.sh | ||
name: Build | ||
env: | ||
ROX_API_TOKEN: $(ROX_API_TOKEN) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that passing in secrets has to be done this way: https://learn.microsoft.com/en-us/azure/devops/pipelines/process/variables?view=azure-devops&tabs=yaml%2Cbatch#secret-variables
Not all the steps here require all the secrets, but this is good enough for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am aware of the issue (still better than when everything was a secret...), but I think this is something that should be handled when rethinking the current Nunjucks generation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree 100%.
22b0c14
to
3ed9470
Compare
Add the template that is used for generating source-repo Azure Pipelines pipelines definition. Secrets have to be passed as environment variables in the workflow files -> include the variables that are needed for Azure to work Include the generated pipeline definitions Signed-off-by: Tomáš Nevrlka <[email protected]>
3ed9470
to
d583f3c
Compare
Based on #137 which should be merged first.
Review the last commit that adds the Azure source-repo pipeline